Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly handle allowEmptyValue #569

Merged
merged 3 commits into from
Aug 30, 2019
Merged

Conversation

XVincentX
Copy link
Contributor

@XVincentX XVincentX commented Aug 29, 2019

Closes #499

philsturgeon
philsturgeon previously approved these changes Aug 29, 2019
@XVincentX XVincentX marked this pull request as ready for review August 30, 2019 12:01
@XVincentX XVincentX force-pushed the fix/allow-empty-value branch 3 times, most recently from d5d169c to d6aad91 Compare August 30, 2019 12:09
@XVincentX XVincentX merged commit 815e254 into master Aug 30, 2019
@XVincentX XVincentX deleted the fix/allow-empty-value branch August 30, 2019 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allowEmptyValue is not respected
2 participants