Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: returning actual body #993

Merged
merged 2 commits into from Feb 19, 2020
Merged

fix: returning actual body #993

merged 2 commits into from Feb 19, 2020

Conversation

karol-maciaszek
Copy link
Contributor

Prism's http-client is no longer returning {} when the body is empty.

XVincentX
XVincentX approved these changes Feb 19, 2020
View reviewed changes
Copy link
Contributor

@XVincentX XVincentX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering why I did this back in the time.

@XVincentX XVincentX merged commit 79c0cc4 into master Feb 19, 2020
@XVincentX XVincentX deleted the fix/client-body-fix branch February 19, 2020 14:08
@karol-maciaszek
Copy link
Contributor Author

karol-maciaszek commented Feb 19, 2020 •
edited

I am wondering why I did this back in the time.

Together with @marcelltoth, we asked the same question while doing git blame :]

@marcelltoth marcelltoth mentioned this pull request Feb 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XVincentX XVincentX XVincentX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@karol-maciaszek @XVincentX