fix(rulesets): handle empty payload and headers in AsyncAPI message's examples validation #2284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magicmatatjahu
added
enhancement
This was referenced Sep 19, 2022
P0lip
force-pushed
the
develop
branch
2 times, most recently
from
29d2c52
to
a7f9fa7
Compare
… examples validation
magicmatatjahu
force-pushed
the
asyncapi/fix-message-examples-rule
branch
2 times, most recently
from
c180dc3
to
dd647d6
Compare
jonaslagoni
requested changes
Oct 5, 2022
|
|
||
| type HaveTraits = { traits?: any[] } & Record<string, any>; | ||
|
|
||
| export function mergeTraits<T extends HaveTraits>(data: T): T { |
There was a problem hiding this comment.
I would probably add some more docs here and specifically stating that this is JSON Merge Patch.
There was a problem hiding this comment.
Done, thanks! :)
|
@P0lip Could you review and merge PR? Thanks! |
P0lip
reviewed
Oct 5, 2022
yarn.lock
Outdated
| @@ -2444,6 +2444,25 @@ __metadata: | |||
| languageName: node | |||
There was a problem hiding this comment.
could you revert this yarn.lock change?
There was a problem hiding this comment.
@P0lip I reverted, but it was very strange, because without execution of yarn tests were failing. Let's see if it passes this time.
magicmatatjahu
force-pushed
the
asyncapi/fix-message-examples-rule
branch
from
baa7c5e
to
d2bfabe
Compare
P0lip
approved these changes
Oct 5, 2022
stoplight-bot
pushed a commit
that referenced
this pull request
Oct 6, 2022
# [@stoplight/spectral-rulesets-v1.14.1](https://github.com/stoplightio/spectral/compare/@stoplight/spectral-rulesets-v1.14.0...@stoplight/spectral-rulesets-v1.14.1) (2022-10-06) ### Bug Fixes * **rulesets:** handle empty payload and headers in AsyncAPI message's examples validation ([#2284](#2284)) ([4068221](4068221))
|
🎉 This PR is included in version @stoplight/spectral-rulesets-v1.14.1 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Does this PR introduce a breaking change?
The current rule for AsyncAPI message's examples not support use cases where payloads or headers may be empty. Also it does not merge traits in first row and then validate. That PR fix these two "bugs".