feat: integrate new parser-api #833
Conversation
magicmatatjahu
force-pushed
the
integrate-new-parser-api
branch
from
d3208fb
to
d99e8f9
Compare
magicmatatjahu
requested review from
fmvilas,
derberg,
jonaslagoni and
asyncapi-bot-eve
as code owners
magicmatatjahu
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
I think I do not understand something 😓
how does the new parser version relate to custom parsers? I'm confused 😄
I left this comment in avro schema parser in the past asyncapi/avro-schema-parser#168 (review)
also, since asyncapi/.github#204 the bump.yml workflow is not going to be replicated in repositories that do not have get-global-node-release-workflows. This means that you can now easily update it in parser repository, in the master branch to make sure regular releases will not revert the version update that you did here.
magicmatatjahu
force-pushed
the
integrate-new-parser-api
branch
from
a645bb5
to
ac51a4e
Compare
magicmatatjahu
requested review from
Florence-Njeri and
pratik2315
as code owners
|
Kudos, SonarCloud Quality Gate passed!
|
| @@ -19,7 +19,7 @@ describe('Integration testing generateFromFile() to make sure the result of the | |||
| return path.resolve(mainTestResultPath, crypto.randomBytes(4).toString('hex')); | |||
| }; | |||
|
|
|||
| jest.setTimeout(30000); | |||
| jest.setTimeout(60000); | |||
There was a problem hiding this comment.
I had to increate timeout to 60s, because on windows integration tests always failed - first test create snapshot and the next one check that snapshot, so at the end all tests failed.
|
@derberg @jonaslagoni I think that we can merge that PR :) I wanna merge it after |
|
@magicmatatjahu got some conflicts. |
|
@magicmatatjahu do you think you will still be able to move forward with this PR? 🙏 |
|
Kudos, SonarCloud Quality Gate passed!
|
|
FInal round of review before merging, I solved the conflicts 🙂 |
There was a problem hiding this comment.
docs wise I was thinking if we need something in https://github.com/asyncapi/generator/blob/master/docs/parser.md but maybe it doesn't make sense as we do not want to have it here for long, I guess
lgtm
|
@magicmatatjahu can you please update the branch with latest |
|
As discussed offline via slack DM, @magicmatatjahu is happy with me creating a new PR with all the new changes needed since it can't handle it atm. This then can be closed in favor of #960 |
|
closing in favour of #960 |
Description
Integrate new ParserJS API:
apiVersion.Related issue(s)
Resolves #825
Part of asyncapi/parser-js#481
Blocked by stoplightio/spectral#2284