Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): improve deep ruleset inheritance #2326

Merged
merged 2 commits into from
Nov 22, 2022

Conversation

P0lip
Copy link
Contributor

@P0lip P0lip commented Nov 2, 2022

Fixes #2211

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

@P0lip P0lip added the t/bug Something isn't working label Nov 2, 2022
@P0lip P0lip self-assigned this Nov 2, 2022
@P0lip P0lip force-pushed the fix/core/ruleset-inheritance branch from 424a836 to 78c157a Compare November 2, 2022 19:22
@P0lip P0lip marked this pull request as ready for review November 15, 2022 15:39
@P0lip P0lip requested a review from a team as a code owner November 15, 2022 15:39
@pavelkornev
Copy link
Contributor

Can this be merged already?

@P0lip P0lip enabled auto-merge (squash) November 22, 2022 12:53
@P0lip P0lip merged commit 378b4b8 into develop Nov 22, 2022
@P0lip P0lip deleted the fix/core/ruleset-inheritance branch November 22, 2022 12:55
stoplight-bot pushed a commit that referenced this pull request Nov 22, 2022
# [@stoplight/spectral-core-v1.15.2](https://github.com/stoplightio/spectral/compare/@stoplight/spectral-core-v1.15.1...@stoplight/spectral-core-v1.15.2) (2022-11-22)

### Bug Fixes

* **core:** improve deep ruleset inheritance ([#2326](#2326)) ([378b4b8](378b4b8))
@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version @stoplight/spectral-core-v1.15.2 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

PagoNxt-Trade pushed a commit to PagoNxt-Trade/spectral that referenced this pull request Dec 1, 2022
PagoNxt-Trade pushed a commit to PagoNxt-Trade/spectral that referenced this pull request Dec 1, 2022
PagoNxt-Trade pushed a commit to PagoNxt-Trade/spectral that referenced this pull request Dec 1, 2022
PagoNxt-Trade pushed a commit to PagoNxt-Trade/spectral that referenced this pull request Dec 1, 2022
PagoNxt-Trade pushed a commit to PagoNxt-Trade/spectral that referenced this pull request Dec 1, 2022
PagoNxt-Trade pushed a commit to PagoNxt-Trade/spectral that referenced this pull request Dec 1, 2022
stoplight-bot pushed a commit that referenced this pull request May 23, 2023
# [6.7.0](v6.6.0...v6.7.0) (2023-05-23)

### Bug Fixes

* **core:** improve deep ruleset inheritance ([#2326](#2326)) ([378b4b8](378b4b8))
* **core:** more accurate ruleset error paths ([66b3ca7](66b3ca7))
* **core:** reset path in fn context ([#2389](#2389)) ([3d47ec4](3d47ec4))
* **ref-resolver:** bump @stoplight/json-ref-resolver from ~3.1.4 to ~3.1.5 ([#3635](https://github.com/stoplightio/spectral/issues/3635)) ([215ae93](215ae93))
* **ruleset-bundler:** defaults should be last one ([#2403](#2403)) ([8780cfa](8780cfa))
* **ruleset-bundler:** remove extraneous 'external dependency' warnings ([#2475](#2475)) ([e791534](e791534))
* **ruleset-migrator:** avoid positive lookbehinds ([#2349](#2349)) ([455c324](455c324))
* **ruleset-migrator:** transform functions under overrides ([#2459](#2459)) ([45e817f](45e817f))
* **ruleset-migrator:** use module for require.resolve ([#2405](#2405)) ([d7c0fa4](d7c0fa4))
* **rulesets:** avoid false errors from ajv ([#2408](#2408)) ([92dab78](92dab78))
* **rulesets:** length.min said "must not be longer than" ([#2355](#2355)) ([df3b6f9](df3b6f9))

### Features

* **core:** relax formats validation ([#2151](#2151)) ([de16b4c](de16b4c))
* **core:** support end-user extensions in the rule definitions ([#2345](#2345)) ([365fced](365fced))
* **core:** support x- extensions in the ruleset ([#2440](#2440)) ([964151e](964151e))
* **formats:** support AsyncAPI 2.6.0 ([#2391](#2391)) ([b8e51b4](b8e51b4))
* **formatters:** move formatters to a separate package ([#2468](#2468)) ([664e259](664e259))
* **rulesets:** add traits array path to headers rule ([#2460](#2460)) ([9ceabca](9ceabca))
* **rulesets:** support AsyncAPI 2.6.0 ([#2391](#2391)) ([94a7801](94a7801))
@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version 6.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released t/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switching rules "off" doesn't work when using chain of inherited rulesets
4 participants