fix(ruleset-bundler): remove extraneous 'external dependency' warnings #2475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billiegoose
force-pushed
the
chore/no-more-external-dependency-warnings-when-bundling
branch
from
ba80f3e
to
476c982
Compare
P0lip
approved these changes
May 17, 2023
There was a problem hiding this comment.
I think it's fine for now.
Ideally, we should perhaps allow custom external . This way we could also get rid of the option we pass here
FWIW, that warning might be actually valuable for some less advanced users of Spectral if they use Spectral programmatically and choose a wrong bundle target, etc.
The reason we can safely keep @stoplight/spectral- imports in our platform is that that ruleset is meant to be used either in Studio or CLI, so the bundling will happen again.
Otherwise, if you, say, have a web app and set node as a bundle target, the imports will be kept, but loading that code will fail.
P0lip
deleted the
chore/no-more-external-dependency-warnings-when-bundling
branch
stoplight-bot
pushed a commit
that referenced
this pull request
May 17, 2023
# [@stoplight/spectral-ruleset-bundler-v1.5.2](https://github.com/stoplightio/spectral/compare/@stoplight/spectral-ruleset-bundler-v1.5.1...@stoplight/spectral-ruleset-bundler-v1.5.2) (2023-05-17) ### Bug Fixes * **ruleset-bundler:** remove extraneous 'external dependency' warnings ([#2475](#2475)) ([e791534](e791534))
|
🎉 This PR is included in version @stoplight/spectral-ruleset-bundler-v1.5.2 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
stoplight-bot
pushed a commit
that referenced
this pull request
May 23, 2023
# [6.7.0](v6.6.0...v6.7.0) (2023-05-23) ### Bug Fixes * **core:** improve deep ruleset inheritance ([#2326](#2326)) ([378b4b8](378b4b8)) * **core:** more accurate ruleset error paths ([66b3ca7](66b3ca7)) * **core:** reset path in fn context ([#2389](#2389)) ([3d47ec4](3d47ec4)) * **ref-resolver:** bump @stoplight/json-ref-resolver from ~3.1.4 to ~3.1.5 ([#3635](https://github.com/stoplightio/spectral/issues/3635)) ([215ae93](215ae93)) * **ruleset-bundler:** defaults should be last one ([#2403](#2403)) ([8780cfa](8780cfa)) * **ruleset-bundler:** remove extraneous 'external dependency' warnings ([#2475](#2475)) ([e791534](e791534)) * **ruleset-migrator:** avoid positive lookbehinds ([#2349](#2349)) ([455c324](455c324)) * **ruleset-migrator:** transform functions under overrides ([#2459](#2459)) ([45e817f](45e817f)) * **ruleset-migrator:** use module for require.resolve ([#2405](#2405)) ([d7c0fa4](d7c0fa4)) * **rulesets:** avoid false errors from ajv ([#2408](#2408)) ([92dab78](92dab78)) * **rulesets:** length.min said "must not be longer than" ([#2355](#2355)) ([df3b6f9](df3b6f9)) ### Features * **core:** relax formats validation ([#2151](#2151)) ([de16b4c](de16b4c)) * **core:** support end-user extensions in the rule definitions ([#2345](#2345)) ([365fced](365fced)) * **core:** support x- extensions in the ruleset ([#2440](#2440)) ([964151e](964151e)) * **formats:** support AsyncAPI 2.6.0 ([#2391](#2391)) ([b8e51b4](b8e51b4)) * **formatters:** move formatters to a separate package ([#2468](#2468)) ([664e259](664e259)) * **rulesets:** add traits array path to headers rule ([#2460](#2460)) ([9ceabca](9ceabca)) * **rulesets:** support AsyncAPI 2.6.0 ([#2391](#2391)) ([94a7801](94a7801))
|
🎉 This PR is included in version 6.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/stoplightio/platform-internal/issues/16525
Checklist
Does this PR introduce a breaking change?
Screenshots
Before:
After:
Additional context
These warnings create noise in our DataDog logs for the
api-designservice.