chore(karma): improve fixtures generation #653
Conversation
P0lip
force-pushed
the
chore/karma
branch
2 times, most recently
from
06962fe
to
fbd688f
Compare
| @@ -7,7 +7,7 @@ | |||
|
|
|||
| /binaries | |||
| /rulesets | |||
| /src/__tests__/__fixtures__/oas-functions.json | |||
| /__karma__/__fixtures__/ | |||
There was a problem hiding this comment.
Doesn't this require a git rm -r --cached . to make sure to remove the old files from the index?
| const files = fs.readdirSync(fnsPath); | ||
| for (const spec of ['', '2', '3']) { | ||
| const target = path.join(baseDir, `oas${spec}-functions.json`); | ||
| const fnsPath = path.join(__dirname, `../rulesets/oas${spec}/functions`); |
There was a problem hiding this comment.
What does fns stand for?
|
|
||
| fs.writeFileSync(target, JSON.stringify(bundledFns, null, 2)) | ||
| fs.writeFileSync(target, JSON.stringify(bundledFns, null, 2)); |
There was a problem hiding this comment.
If I understand correctly what this function is doing is reading 3 files and then write all of them back in a single file?
There was a problem hiding this comment.
Almost.
It reads contents of 3 directories, namely /src/rulesets/oas/functions, /src/rulesets/oas2/functions, /src/rulesets/oas3/functions and the files located there.
Then, it reads each file, and assigns its content to the property, and eventually all files located in a given directory gets saved to a single json (oas-function.json or oas2-functions.json or oas3-functions.json).
This is needed only for Karma tests. The files are imported here https://github.com/stoplightio/spectral/pull/653/files/31f24d2c70187af125e651b2f2ef9b0462638d91#diff-803b3736a08e0afcf28f5dac4102eeb7R10-R13
Needed for #635