Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codesandbox examples build but error when run #237

Closed
olizilla opened this issue Jan 9, 2023 · 1 comment · Fixed by #292
Closed

codesandbox examples build but error when run #237

olizilla opened this issue Jan 9, 2023 · 1 comment · Fixed by #292

Comments

@olizilla
Copy link
Contributor

olizilla commented Jan 9, 2023 •
edited
Loading

We've got codesandox-ci running on our PRs and it seems to build fine, but trying to run the examples fails with an error, and no debugging info.

of note:

  • it only supports building via npm which is probably the cause of our examples not being runnable.
  • codesandbox only supports up to node v16.

It may not be possible to make our build work in npm now we rely on features of pnpm, so we may have to disable pnpm ci, as it's a confusing signal for us to get green check on PRs even when the examples fail to run.

example build: https://ci.codesandbox.io/status/web3-storage/w3ui/pr/220
example sandbox: https://codesandbox.io/s/w3ui-example-react-sign-up-in-z6obt1
@travis
Copy link
Contributor

travis commented Jan 9, 2023

oh dang :-/ I'm on board with dropping codesandbox - I remember poking around at it before the break and it seemed like the lack of support for pnpm and node 18 were symptomatic of a general lack of updates/support for it, so maybe time to move on?

it would still be nice to have the examples available in something like codesandbox, are there alternatives out there?

olizilla added a commit that referenced this issue Jan 24, 2023
@olizilla
chore: get codesandbox examples working again
f8203fc 
- codesansbox ci now support node 18
- set installCommand to use pnpm from npm
- disable buildCommand as it is done after install by the prepare lifecycle script

fixes #237

note: there is an issue to consolidate the examples in #256 but our current set of examples are linked to from beta.ui.web3.storage so if we can get them working again without too much pain I think we should.

License: MIT
Signed-off-by: Oli Evans <oli@protocol.ai>
@olizilla olizilla mentioned this issue Jan 24, 2023
Merged
travis added a commit that referenced this issue Jan 25, 2023
@olizilla @travis
chore: get codesandbox examples working again (#292)
b02f6e0 
- codesansbox ci now support node 18
- disable `buildCommand` as it is done after install by the prepare
lifecycle script

see: https://codesandbox.io/docs/learn/sandboxes/ci#configuration-format

fixes #237

note: there is an issue to consolidate the examples in #256 but our
current set of examples are linked to from beta.ui.web3.storage so if we
can get them working again without too much pain I think we should.

License: MIT
Signed-off-by: Oli Evans <oli@protocol.ai>

Signed-off-by: Oli Evans <oli@protocol.ai>
Co-authored-by: Travis Vachon <travis.vachon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: get codesandbox examples working again storacha-network/w3ui
2 participants
@travis @olizilla