chore: get codesandbox examples working again #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- codesansbox ci now support node 18 - set installCommand to use pnpm from npm - disable buildCommand as it is done after install by the prepare lifecycle script fixes #237 note: there is an issue to consolidate the examples in #256 but our current set of examples are linked to from beta.ui.web3.storage so if we can get them working again without too much pain I think we should. License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e570fdd:
|
License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
olizilla
commented
Jan 24, 2023
we dont need the carbuncle! License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
|
Also looks like codesandbox has added support for pnpm, as it's automatically detecting it in CI, see: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
buildCommandas it is done after install by the prepare lifecycle scriptsee: https://codesandbox.io/docs/learn/sandboxes/ci#configuration-format
fixes #237
note: there is an issue to consolidate the examples in #256 but our current set of examples are linked to from beta.ui.web3.storage so if we can get them working again without too much pain I think we should.
License: MIT
Signed-off-by: Oli Evans oli@protocol.ai