-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: upgrade data segment #850
Conversation
a9ba701
to
dd40d99
Compare
dd40d99
to
9f0aa7d
Compare
9f0aa7d
to
bbc09f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good except I think there is some misunderstanding around legacy CID and PieceInfo
. We should not need to use either, only reason I had them in the data-segment lib is for compat tests with existing libs and tests & I hope to remove that once they transition to v2.
height: piece.height, | ||
size: piece.size, | ||
root: piece.root, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why capture root here as opposed to CID of the piece ?
d083838
to
85771c0
Compare
🤖 I have created a release *beep* *boop* --- ## [9.0.1](capabilities-v9.0.0...capabilities-v9.0.1) (2023-08-10) ### Bug Fixes * upgrade data segment ([#850](#850)) ([fba281f](fba281f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ## 1.0.0 (2023-08-10) ### Features * w3filecoin new client and api ([#848](#848)) ([7a58fbe](7a58fbe)) ### Bug Fixes * upgrade data segment ([#850](#850)) ([fba281f](fba281f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ## 1.0.0 (2023-08-10) ### Features * w3filecoin new client and api ([#848](#848)) ([7a58fbe](7a58fbe)) ### Bug Fixes * upgrade data segment ([#850](#850)) ([fba281f](fba281f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Vasco Santos <santos.vasco10@gmail.com>
🤖 I have created a release *beep* *boop* --- ## [1.2.0](filecoin-api-v1.1.0...filecoin-api-v1.2.0) (2023-08-10) ### Features * w3filecoin new client and api ([#848](#848)) ([7a58fbe](7a58fbe)) ### Bug Fixes * upgrade data segment ([#850](#850)) ([fba281f](fba281f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ## [1.2.0](filecoin-client-v1.1.0...filecoin-client-v1.2.0) (2023-08-10) ### Features * w3filecoin new client and api ([#848](#848)) ([7a58fbe](7a58fbe)) ### Bug Fixes * upgrade data segment ([#850](#850)) ([fba281f](fba281f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Vasco Santos <santos.vasco10@gmail.com>
🤖 I have created a release *beep* *boop* --- ## [1.3.0](filecoin-client-v1.2.2...filecoin-client-v1.3.0) (2023-08-30) ### Features * w3filecoin new client and api ([#848](#848)) ([7a58fbe](7a58fbe)) ### Bug Fixes * upgrade data segment ([#850](#850)) ([fba281f](fba281f)) * w3filecoin spec separate capabilities to queue and enqueue ([#856](#856)) ([6bf9142](6bf9142)), closes [#855](#855) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ## [1.3.0](filecoin-api-v1.2.2...filecoin-api-v1.3.0) (2023-08-30) ### Features * w3filecoin new client and api ([#848](#848)) ([7a58fbe](7a58fbe)) ### Bug Fixes * upgrade data segment ([#850](#850)) ([fba281f](fba281f)) * w3filecoin spec separate capabilities to queue and enqueue ([#856](#856)) ([6bf9142](6bf9142)), closes [#855](#855) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Vasco Santos <santos.vasco10@gmail.com>
🤖 I have created a release *beep* *boop* --- ## [1.4.0](filecoin-api-v1.3.1...filecoin-api-v1.4.0) (2023-08-30) ### Features * w3filecoin new client and api ([#848](#848)) ([7a58fbe](7a58fbe)) ### Bug Fixes * types when storefront is not in capability nb ([#886](#886)) ([448a7d1](448a7d1)) * upgrade data segment ([#850](#850)) ([fba281f](fba281f)) * w3filecoin spec separate capabilities to queue and enqueue ([#856](#856)) ([6bf9142](6bf9142)), closes [#855](#855) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Upgrades
data-segment
lib with Piece CID v2 storacha-network/data-segment#21Needs: