fix: upgrade data segment #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
force-pushed
the
fix/upgrade-data-segment
branch
from
a9ba701
to
dd40d99
Compare
vasco-santos
force-pushed
the
fix/upgrade-data-segment
branch
from
dd40d99
to
9f0aa7d
Compare
vasco-santos
force-pushed
the
fix/upgrade-data-segment
branch
from
9f0aa7d
to
bbc09f6
Compare
3 tasks
Gozala
requested changes
Aug 9, 2023
There was a problem hiding this comment.
All looks good except I think there is some misunderstanding around legacy CID and PieceInfo. We should not need to use either, only reason I had them in the data-segment lib is for compat tests with existing libs and tests & I hope to remove that once they transition to v2.
| height: piece.height, | ||
| size: piece.size, | ||
| root: piece.root, |
There was a problem hiding this comment.
Why capture root here as opposed to CID of the piece ?
vasco-santos
force-pushed
the
fix/upgrade-data-segment
branch
from
d083838
to
85771c0
Compare
Gozala
approved these changes
Aug 9, 2023
This was referenced Aug 10, 2023
vasco-santos
pushed a commit
that referenced
this pull request
Aug 10, 2023
🤖 I have created a release *beep* *boop* --- ## [9.0.1](capabilities-v9.0.0...capabilities-v9.0.1) (2023-08-10) ### Bug Fixes * upgrade data segment ([#850](#850)) ([fba281f](fba281f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
vasco-santos
pushed a commit
that referenced
this pull request
Aug 10, 2023
🤖 I have created a release *beep* *boop* --- ## 1.0.0 (2023-08-10) ### Features * w3filecoin new client and api ([#848](#848)) ([7a58fbe](7a58fbe)) ### Bug Fixes * upgrade data segment ([#850](#850)) ([fba281f](fba281f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
vasco-santos
added a commit
that referenced
this pull request
Aug 10, 2023
🤖 I have created a release *beep* *boop* --- ## 1.0.0 (2023-08-10) ### Features * w3filecoin new client and api ([#848](#848)) ([7a58fbe](7a58fbe)) ### Bug Fixes * upgrade data segment ([#850](#850)) ([fba281f](fba281f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Vasco Santos <santos.vasco10@gmail.com>
This was referenced Aug 10, 2023
vasco-santos
pushed a commit
that referenced
this pull request
Aug 10, 2023
🤖 I have created a release *beep* *boop* --- ## [1.2.0](filecoin-api-v1.1.0...filecoin-api-v1.2.0) (2023-08-10) ### Features * w3filecoin new client and api ([#848](#848)) ([7a58fbe](7a58fbe)) ### Bug Fixes * upgrade data segment ([#850](#850)) ([fba281f](fba281f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
vasco-santos
added a commit
that referenced
this pull request
Aug 10, 2023
🤖 I have created a release *beep* *boop* --- ## [1.2.0](filecoin-client-v1.1.0...filecoin-client-v1.2.0) (2023-08-10) ### Features * w3filecoin new client and api ([#848](#848)) ([7a58fbe](7a58fbe)) ### Bug Fixes * upgrade data segment ([#850](#850)) ([fba281f](fba281f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Vasco Santos <santos.vasco10@gmail.com>
This was referenced Aug 30, 2023
vasco-santos
pushed a commit
that referenced
this pull request
Aug 30, 2023
🤖 I have created a release *beep* *boop* --- ## [1.3.0](filecoin-client-v1.2.2...filecoin-client-v1.3.0) (2023-08-30) ### Features * w3filecoin new client and api ([#848](#848)) ([7a58fbe](7a58fbe)) ### Bug Fixes * upgrade data segment ([#850](#850)) ([fba281f](fba281f)) * w3filecoin spec separate capabilities to queue and enqueue ([#856](#856)) ([6bf9142](6bf9142)), closes [#855](#855) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
vasco-santos
added a commit
that referenced
this pull request
Aug 30, 2023
🤖 I have created a release *beep* *boop* --- ## [1.3.0](filecoin-api-v1.2.2...filecoin-api-v1.3.0) (2023-08-30) ### Features * w3filecoin new client and api ([#848](#848)) ([7a58fbe](7a58fbe)) ### Bug Fixes * upgrade data segment ([#850](#850)) ([fba281f](fba281f)) * w3filecoin spec separate capabilities to queue and enqueue ([#856](#856)) ([6bf9142](6bf9142)), closes [#855](#855) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Vasco Santos <santos.vasco10@gmail.com>
vasco-santos
pushed a commit
that referenced
this pull request
Aug 30, 2023
🤖 I have created a release *beep* *boop* --- ## [1.4.0](filecoin-api-v1.3.1...filecoin-api-v1.4.0) (2023-08-30) ### Features * w3filecoin new client and api ([#848](#848)) ([7a58fbe](7a58fbe)) ### Bug Fixes * types when storefront is not in capability nb ([#886](#886)) ([448a7d1](448a7d1)) * upgrade data segment ([#850](#850)) ([fba281f](fba281f)) * w3filecoin spec separate capabilities to queue and enqueue ([#856](#856)) ([6bf9142](6bf9142)), closes [#855](#855) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades
data-segmentlib with Piece CID v2 storacha-network/data-segment#21Needs: