feat: only use native fetch type and Headers object #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gozala
requested changes
Oct 11, 2022
There was a problem hiding this comment.
Hey @hugomrdias I'm afraid Headers aren't a thing even in node 16 which is current TLS version, which is also why I originally not used them.
Can we address original issue without breaking node 16 support or introducing dependence on an external library ?
|
Problem this was addressing is fixed by #113, we can revisit this after node is 18 TLS and available on AWS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avoid ts errors when passing fetch implementation and normally we only have Headers object in all the env so no need to deal we other types