Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement .delegate on capabilities #110

Merged
merged 15 commits into from
Oct 16, 2022
Merged

Conversation

Gozala
Copy link
Collaborator

@Gozala Gozala commented Oct 12, 2022

This adds .delegate method to the capability defs which:

  1. Validates with and provided nb fields.
  2. Unlike invoke / create it allows omitting nb fields, because in delegation all the nbs are optional.
  3. It does not currently does proof validation because that would require PrincipalParser and capability loaders to be provided. I think we'll be able to add that in the future once we have Agent abstraction that will be passed into issuer field.

All in all it improves things by:

  1. Removing a need to call .delegate() after .invoke(...).
  2. Removes a need for marking nb fields optional in capabilty def.

Note this is based on #109 and targets it as opposed to main branch to reduce need for doing conflict resolution.

@hugomrdias hugomrdias added this to the 0.9 milestone Oct 14, 2022
@Gozala Gozala changed the base branch from feat/remove-my-caps to main October 16, 2022 17:21
@Gozala Gozala merged commit fd0bb9d into main Oct 16, 2022
@Gozala Gozala mentioned this pull request Dec 2, 2022
This was referenced Dec 14, 2022
This was referenced Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants