feat: dont use ipfs-utils fetch with upload progress by default #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orting it in bundled setups breaks
gobengo
changed the title
travis
approved these changes
Dec 13, 2023
| // the fetch implementation didn't support onUploadProgress | ||
| const carBlob = new Blob([car]) | ||
| options.onUploadProgress({ | ||
| total: carBlob.size, |
There was a problem hiding this comment.
are total and loaded here the same because this will be the only progress event sent?
There was a problem hiding this comment.
yep! the only progress even for this car file, and all we know here is the fetch succeeded so it's 100% progress all at once
alanshaw
reviewed
Dec 13, 2023
| /** @type {(url: string, init?: import('./types.js').FetchOptions) => Promise<Response>} */ ( | ||
| fetch | ||
| ) | ||
| options.fetchWithUploadProgress || options.fetch || globalThis.fetch |
There was a problem hiding this comment.
Needs globalThis.fetch.bind(globalThis)
There was a problem hiding this comment.
Just call it customFetch and type it as required?
| IpfsUtilsFetchOptions, | ||
| { | ||
| // `fetch` is a browser API and browsers don't have `Readable` | ||
| body: Exclude<IpfsUtilsFetchOptions['body'], import('node:stream').Readable> |
There was a problem hiding this comment.
it excludes Readable from the allowed body types that come from ipfs-utils because that's not what other fetches will expect
| @@ -0,0 +1,8 @@ | |||
| import ipfsUtilsFetch from 'ipfs-utils/src/http/fetch.js' | |||
There was a problem hiding this comment.
🙏 Pull out as a separate library that solves the issue or send a PR.
travis
added a commit
that referenced
this pull request
Jan 3, 2024
🤖 I have created a release *beep* *boop* --- ## [13.0.0](upload-client-v12.3.2...upload-client-v13.0.0) (2023-12-14) ### ⚠ BREAKING CHANGES * return allocated bytes in `store/add` receipt ([#1213](#1213)) ### Features * dont use ipfs-utils fetch with upload progress by default ([#1240](#1240)) ([86aedbc](86aedbc)) * return allocated bytes in `store/add` receipt ([#1213](#1213)) ([5d52e44](5d52e44)) ### Fixes * bind globalThis.fetch to globalThis ([#1242](#1242)) ([ef59358](ef59358)) * point `main` at files included in the package ([#1241](#1241)) ([c0b306d](c0b306d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Travis Vachon <travis.vachon@protocol.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because importing it in bundled setups breaks, e.g.
I tested this change locally and confirmed that once it's made, upload-client can be relied on by a nextjs project and build successfully