Timeshift for Fedora 32 made easy #873
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Severity: Major: (Major loss of function.) Summary: The Blivet code screens out the @ sign from device names causing Fedora to limit btrfs subvolume names. The design of the Ubuntu installer program, ubiquity, has made it normal and expected for btrfs subvolume names to consist of strings starting with a commercial at sign (e.g. @ and @home). OpenSUSE and Manajaro teams have adopted this convention. Notably the timeshift program requires this to support btrfs. Reproduce steps: 1. Install Fedora 32 via the Workstation or Server installer from getfedora.org. 2. Attempt to use blivet to put / on a btrfs subvolume named @ Expected result: You should have / on a btrfs subvolume named @ Actual result: / is on a btrfs subvolume named btrfs.1234 (or other digits).
|
Two links as background material discussing Timeshift on Fedora |
vojtechtrefny
requested changes
Jul 14, 2020
There was a problem hiding this comment.
Interesting, I didn't know that btrfs allows @ in the subvolume name/label. Anyway, this will need a bigger change -- the safe_device_name function is used for all device types, not only btrfs and some (like LVM) don't allow special characters in device names. So we'll need to make the substitute pattern device type specific to make this work.
|
I've created a new PR with different "safe" names for different device types: #878 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Severity: Major: (Major loss of function.)
Summary: The Blivet code screens out the @ sign from device names causing Fedora to limit btrfs subvolume names. The design of the Ubuntu installer program, ubiquity, has made it normal and expected for btrfs subvolume names to consist of strings starting with a commercial at sign (e.g. @ and @home). OpenSUSE and Manajaro teams have adopted this convention. Notably the timeshift program requires this to support btrfs.
Reproduce steps:
Expected result: You should have / on a btrfs subvolume named @
Actual result: / is on a btrfs subvolume named btrfs.1234 (or other digits).