Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make safe_device_name device type specific #878

Conversation

vojtechtrefny
Copy link
Member

This allows us to have a different safe device names for different
device types and for example allow characters like "@" and "/" for
btrfs only.

This allows us to have a different safe device names for different
device types and for example allow characters like "@" and "/" for
btrfs only.
Copy link
Contributor

@dwlehman dwlehman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I don't know if I love using the devicefactory type constants outside the factory flow, but they are there and serve the purpose well enough for now.

@vojtechtrefny
Copy link
Member Author

Looks good to me. I don't know if I love using the devicefactory type constants outside the factory flow, but they are there and serve the purpose well enough for now.

I was thinking about using strings, but that would be even worse. We should think about adding some constants file for these purposes.

@vojtechtrefny vojtechtrefny merged commit 7c41886 into storaged-project:3.2-devel Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants