nvme: Health Information

[tbzatek]

(the first commits are from #973)

NVMe SMART / Health Information (Log Identifier 02h) support

TODO:

• trigger a self-test
• sanitize
• provide time estimates for self-tests and sanitize operations
• error log retrieval
• error messages: check controller capabilities prior to issuing commands (that would typically fail with a cryptic error message)
• when self-test/sanitize/format operation is running as a result of an external action, shall we poll until it's finished?

Fixes #386

[tbzatek]

Rebased, ready for review.

The two points outlined in the description are still valid but I plan to address them later.

[vojtechtrefny]

Looks good to me.

[tbzatek]

Jenkins, test this please.

[vojtechtrefny]

Still looks good, thank you for the assert replacements.

[papylhomme]

@tbzatek any ETA for a release including this ?

[tbzatek]

@tbzatek any ETA for a release including this ?

Well, we first need to finish the API changes we're currently making for the libblockdev-3.0 release, followed by some more porting and refactoring in UDisks. Translations need to be dealt with also. The target is currently before the end of this year.

NVMe-related, #983 is still pending on review. I would still like to sneak NVMeoF discovery in if possible. The NVMe support received only minimal testing so far and needs to be tested on real drives to ensure the new API is useful and reasonably future proof.

If you could test snapshots of libblockdev and udisks in the meantime and/or post any more requirements, we might still make the changes before the API is released in public.

[papylhomme]

Perfect, building libblockdev right now, I'll let you know if I miss anything

[MrPippin66]

Is the code path to include a new node 'drive.nvme' being considered or still in progress?

[tbzatek]

Is the code path to include a new node 'drive.nvme' being considered or still in progress?

If you check status of this pull request, you can see 'Merged'.