-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nvme: Fabrics #983
Merged
Merged
nvme: Fabrics #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rebased, ready for review. |
Jenkins, test this please. |
tbzatek
force-pushed
the
nvme-base-3
branch
3 times, most recently
from
August 4, 2022 14:12
1258bce
to
361c0ac
Compare
vojtechtrefny
approved these changes
Sep 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Just few nitpicks and suggestions.
NVMe over Fabrics awareness and a simple way to connect and disconnect. No discovery for the moment.
…rface Makes more sense along the Fabrics interface.
Turned out it's not needed after all, nvme-cli falls back to autogenerated Host NQN when not supplied.
Just like in libblockdev, the tests hardcode the /etc sysconfig paths.
Jenkins, test this please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intentionally skipped anything around discovery for the moment, need to gain more hands-on experience before attempting to create any API.
Needs storaged-project/libblockdev#746