Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nvme: Fabrics #983

Merged
merged 8 commits into from
Sep 14, 2022
Merged

nvme: Fabrics #983

merged 8 commits into from
Sep 14, 2022

Conversation

tbzatek
Copy link
Member

@tbzatek tbzatek commented Jun 7, 2022

Intentionally skipped anything around discovery for the moment, need to gain more hands-on experience before attempting to create any API.

Needs storaged-project/libblockdev#746

@tbzatek
Copy link
Member Author

tbzatek commented Aug 1, 2022

Rebased, ready for review.

@tbzatek
Copy link
Member Author

tbzatek commented Aug 3, 2022

Jenkins, test this please.

@tbzatek tbzatek force-pushed the nvme-base-3 branch 3 times, most recently from 1258bce to 361c0ac Compare August 4, 2022 14:12
@tbzatek tbzatek mentioned this pull request Aug 15, 2022
6 tasks
src/udiskslinuxmanagernvme.c Outdated Show resolved Hide resolved
src/udiskslinuxmanagernvme.c Outdated Show resolved Hide resolved
src/tests/dbus-tests/test_nvme.py Outdated Show resolved Hide resolved
Copy link
Member

@vojtechtrefny vojtechtrefny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just few nitpicks and suggestions.

NVMe over Fabrics awareness and a simple way to connect and disconnect.
No discovery for the moment.
…rface

Makes more sense along the Fabrics interface.
Turned out it's not needed after all, nvme-cli falls back
to autogenerated Host NQN when not supplied.
Just like in libblockdev, the tests hardcode the /etc sysconfig paths.
@tbzatek
Copy link
Member Author

tbzatek commented Sep 8, 2022

Jenkins, test this please.

@tbzatek tbzatek merged commit 59378cd into storaged-project:master Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants