This repository is currently being migrated. It's locked while the migration is in progress.
enable AZ-aa by default #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolancon
approved these changes
Jun 17, 2022
angelos-p
reviewed
Jun 17, 2022
| @@ -51,3 +51,13 @@ spec: | |||
| values: | |||
| - storageos-etcd | |||
| topologyKey: kubernetes.io/hostname | |||
| preferredDuringSchedulingIgnoredDuringExecution: | |||
| - weight: 1 | |||
There was a problem hiding this comment.
I think weight 1 is too low, this should be changed to 100. A weight of 1 is almost inconsequential: https://aws.amazon.com/blogs/developer/aws-cli-v2-is-now-generally-available/
There was a problem hiding this comment.
I think weight 1 is too low, this should be changed to 100.
We plan to patch this with kustomize if the user sets a topology key when installing via the plugin
We're only adding it here (and therefore setting it as default), as limitations with the plugin make it difficult to add an entire new entire object via a kustomize patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables spreading etcd pods between AZs by default.
As it's
preferredit should have no effect if a cluster does not have any AZs