Skip to content
This repository is currently being migrated. It's locked while the migration is in progress.

enable AZ-aa by default #43

Merged
merged 1 commit into from
Jun 17, 2022
Merged

enable AZ-aa by default #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 10 additions & 0 deletions config/samples/storageos-etcd-cluster.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,3 +51,13 @@ spec:
values:
- storageos-etcd
topologyKey: kubernetes.io/hostname
preferredDuringSchedulingIgnoredDuringExecution:
- weight: 1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think weight 1 is too low, this should be changed to 100. A weight of 1 is almost inconsequential: https://aws.amazon.com/blogs/developer/aws-cli-v2-is-now-generally-available/

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think weight 1 is too low, this should be changed to 100.

We plan to patch this with kustomize if the user sets a topology key when installing via the plugin

We're only adding it here (and therefore setting it as default), as limitations with the plugin make it difficult to add an entire new entire object via a kustomize patch.

podAffinityTerm:
labelSelector:
matchExpressions:
- key: etcd.improbable.io/cluster-name
operator: In
values:
- storageos-etcd
topologyKey: topology.kubernetes.io/zone