CU-86950b3em Order shipment sync M2 -> SK Created observer event and consumer which processes ship… #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment created on M2 admin and sync it with SK order
ikulis
reviewed
Jul 7, 2024
Model/OrderSync/ShipmentConsumer.php
Outdated
Comment on lines
52
to
58
| $shipmentId = $this->orderApiClient->newOrderShipment( | ||
| $data['storekeeper_id'], | ||
| $data['items'], | ||
| $data['store_id'] | ||
| ); | ||
|
|
||
| $this->orderApiClient->markOrderShipmentDelivered($data['store_id'], $shipmentId); |
There was a problem hiding this comment.
can you add to readme that we synchronize the shipments and mark them as deliveted in storekeeper right away?
…"storekeeper.queue.sync.shipments" to observer event "shipment_save_before". Added new order flag 'order_detached' which have default value of false, can be switched from 'Storekeeper' order view tab, and allows to bypass given order in all ks-related sync processes
ikulis
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check before PR #74