This repository has been archived by the owner on Oct 30, 2018. It is now read-only.
Give default values for responseTime and reputation if not already set #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This covers the case that a contact is added via Kad which does not have these default values set. Because the contact will need to be updated with `spaceAvailable:true` to start receiving data, we can also verify that responseTime and reputation have default values so that the farmer will be selected to store data.
This was referenced Jan 3, 2018
|
Looks good to me. |
littleskunk
approved these changes
Jan 3, 2018
braydonf
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers the case that a contact is added via Kad which does not have these default values set. Because the contact will need to be updated with
spaceAvailable:trueto start receiving data, we can also verify that responseTime and reputation have default values so that the farmer will be selected to store data.cc: @tempestb @littleskunk