This repository has been archived by the owner on Oct 30, 2018. It is now read-only.
[WIP] Include responseTime and reputation if available #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick fix until we deal with the high levels of software entropy that has accumulated.
There are two models for a "Contact" one that exists here in lib/network/contact, and another one is lib/models/contact of MongoDB models. The two come into confusion at: https://github.com/Storj/service-storage-models/blob/master/lib/models/contact.js#L90 where this one is passed into the MongoDB models version, which often lacks all the properties, making it near impossible to set a default value, without inadvertently reseting the value.