Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mail.test as domain in emails #2224

Merged
merged 3 commits into from
Jun 18, 2019
Merged

Use mail.test as domain in emails #2224

merged 3 commits into from
Jun 18, 2019

Conversation

egonelbre
Copy link
Member

Any testing data should use .test TLD. While example.com is probably not too bad, it's still preferred to use .test.

See https://en.wikipedia.org/wiki/.test

Thanks for submitting a PR!

Code Review Checklist (to be filled out by reviewer)

  • Does the PR describe what changes are being made?
  • Does the PR describe why the changes are being made?
  • Does the code follow our style guide?
  • Does the code follow our testing guide?
  • Could the PR be broken into smaller PRs?
  • Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • Does any documentation need updating?

Copy link
Contributor

@VinozzZ VinozzZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just curious why it's not ideal to use.com for example emails?

@egonelbre
Copy link
Member Author

Because this can end in sending testing data to people. example.com probably is fine, but everything else (e.g. mail.com, initech.com) belong to actual companies and people.

.test is specifically designed such that it doesn't belong to anyone and noone can register a domain with it.

@egonelbre egonelbre added Request Code Review Code review requested Reviewer Can Merge If all checks have passed, non-owner can merge PR labels Jun 17, 2019
@stefanbenten stefanbenten merged commit f4f776d into master Jun 18, 2019
@stefanbenten stefanbenten deleted the ee/fix-domain branch June 18, 2019 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Request Code Review Code review requested Reviewer Can Merge If all checks have passed, non-owner can merge PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants