Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

discovery: use fetch info to ping #2491

Merged
merged 2 commits into from
Jul 9, 2019
Merged

discovery: use fetch info to ping #2491

merged 2 commits into from
Jul 9, 2019

Conversation

jtolio
Copy link
Member

@jtolio jtolio commented Jul 9, 2019

this will reduce the amount of network operations and roundtrips in successful cases by a factor of 2

still todo: combine the db updates

Please describe the performance impact: have to hit the node only once instead of twice

Code Review Checklist (to be filled out by reviewer)

  • Does the PR describe what changes are being made?
  • Does the PR describe why the changes are being made?
  • Does the code follow our style guide?
  • Does the code follow our testing guide?
  • Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
  • Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • Does any documentation need updating?
  • Do the database access patterns make sense?

@jtolio
discovery: use fetch info to ping
d74b0be 
this will reduce the amount of network operations and roundtrips
in successful cases by a factor of 2

Change-Id: I926034b35d7258b016dadbda91eea267684053c5
@cla-bot cla-bot bot added the cla-signed label Jul 9, 2019
@jtolio jtolio added Request Code Review Code review requested Reviewer Can Merge If all checks have passed, non-owner can merge PR labels Jul 9, 2019
@stefanbenten stefanbenten merged commit 887b784 into master Jul 9, 2019
@stefanbenten stefanbenten deleted the jt/node-ping branch July 9, 2019 02:10
littleskunk pushed a commit that referenced this pull request Jul 9, 2019
@jtolio @littleskunk
discovery: use fetch info to ping (#2491)
a988592 

(cherry picked from commit 887b784)
@storjrobot
Copy link

This pull request has been mentioned on Storj Labs Community Forum: Decentralized Cloud Storage. There might be relevant details there:

https://forum.storj.io/t/changelog-v0-14-11/433/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@littleskunk littleskunk littleskunk approved these changes

@stefanbenten stefanbenten stefanbenten approved these changes

Assignees
No one assigned
Labels
cla-signed Request Code Review Code review requested Reviewer Can Merge If all checks have passed, non-owner can merge PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jtolio @storjrobot @littleskunk @stefanbenten