Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/version: Change default endpoint to query #3126

Merged
merged 2 commits into from
Sep 25, 2019
Merged

internal/version: Change default endpoint to query #3126

merged 2 commits into from
Sep 25, 2019

Conversation

stefanbenten
Copy link
Contributor

@stefanbenten stefanbenten commented Sep 25, 2019 •
edited by mniewrzal

What: changes the service to ask version.storj.io instead of version.alpha.storj.io

Why: It allows autoupdating

Code Review Checklist (to be filled out by reviewer)

  • Does the PR describe what changes are being made?
  • Does the PR describe why the changes are being made?
  • Does the code follow our style guide?
  • Does the code follow our testing guide?
  • Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
  • Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • Does any documentation need updating?
  • Do the database access patterns make sense?

@stefanbenten
change default domain name
785af05 
change default domain name to point to the new version control
@stefanbenten stefanbenten added Request Code Review Code review requested Reviewer Can Merge If all checks have passed, non-owner can merge PR labels Sep 25, 2019
@stefanbenten stefanbenten requested a review from a team September 25, 2019 20:23
@cla-bot cla-bot bot added the cla-signed label Sep 25, 2019
@ghost ghost requested review from Barterio and rikysya and removed request for a team September 25, 2019 20:23
mniewrzal
mniewrzal previously approved these changes Sep 25, 2019
View reviewed changes
kaloyan-raev
kaloyan-raev previously approved these changes Sep 25, 2019
View reviewed changes
Barterio
Barterio previously approved these changes Sep 25, 2019
View reviewed changes
@littleskunk littleskunk merged commit c71f3a3 into master Sep 25, 2019
@littleskunk littleskunk deleted the sb/default-version branch September 25, 2019 20:55
littleskunk pushed a commit that referenced this pull request Sep 25, 2019
@stefanbenten @littleskunk
internal/version: Change default endpoint to query (#3126)
7f3da50 
* change default domain name

change default domain name to point to the new version control

* Update satellite-config.yaml.lock

(cherry picked from commit c71f3a3)
bryanchriswhite added a commit that referenced this pull request Sep 26, 2019
@bryanchriswhite
Merge remote-tracking branch 'storj/master' into bryan/certificates
448ffbf 
* storj/master:
  web/satellite: vue style guide applying for UI (#3112)
  internal/testplanet: ensure monitor chore is finished before contacting satellite (#3124)
  build: make binaries smaller with -s and -w ldflags (#3125)
  satellite/satellitedb: update node version columns in UpdateCheckIn (#3129)
  all: use pkg/rpc instead of pkg/transport
  internal/version: Change default endpoint to query (#3126)
  satellite/satellitedb: Initial GE Satellite DB Implementation (#3049)
  satellite/accounting/rollup: pause in tests (#3122)
  jenkins: update golangci to v1.19.1 (#3119)
  satellite/accounting/tally: ensure we have a root piece id (#3123)
  internal/testplanet: set intervals to 15s by default (#3103)
  jenkins: disable flaky test-certificates (#3111)
  storagenode: avoid starting command on service stop (#3105)
  storagenode/winsvc: avoid the 15s sleep when stopping the service (#3098)
  fix certificates auth export command (#3110)
  satellite/repair/checker: set erasure share size in tests (#3101)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaloyan-raev kaloyan-raev kaloyan-raev approved these changes

@littleskunk littleskunk littleskunk approved these changes

@mniewrzal mniewrzal mniewrzal approved these changes

@rikysya rikysya Awaiting requested review from rikysya

@Barterio Barterio Awaiting requested review from Barterio

Assignees
No one assigned
Labels
cla-signed Request Code Review Code review requested Reviewer Can Merge If all checks have passed, non-owner can merge PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@stefanbenten @kaloyan-raev @Barterio @littleskunk @mniewrzal