Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

satellite/satellitedb: update node version columns in UpdateCheckIn #3129

Merged
merged 5 commits into from
Sep 26, 2019
Merged

satellite/satellitedb: update node version columns in UpdateCheckIn #3129

merged 5 commits into from
Sep 26, 2019

Conversation

cam-a
Copy link
Contributor

@cam-a cam-a commented Sep 25, 2019 •
edited by stefanbenten

What: Update the node's version in overlay cache

Why: We missed the node version columns in the update

Please describe the performance impact:

Code Review Checklist (to be filled out by reviewer)

  • Does the PR describe what changes are being made?
  • Does the PR describe why the changes are being made?
  • Does the code follow our style guide?
  • Does the code follow our testing guide?
  • Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
  • Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • Does any documentation need updating?
  • Do the database access patterns make sense?

@cam-a cam-a requested review from littleskunk, JessicaGreben and a team September 25, 2019 23:14
@cla-bot cla-bot bot added the cla-signed label Sep 25, 2019
@ghost ghost requested review from VinozzZ and removed request for a team September 25, 2019 23:14
littleskunk
littleskunk previously approved these changes Sep 25, 2019
View reviewed changes
stefanbenten
stefanbenten previously approved these changes Sep 25, 2019
View reviewed changes
littleskunk
littleskunk previously approved these changes Sep 25, 2019
View reviewed changes
@cam-a cam-a dismissed stale reviews from littleskunk and stefanbenten via 521ee62 September 25, 2019 23:52
stefanbenten
stefanbenten approved these changes Sep 26, 2019
View reviewed changes
Copy link
Contributor

@stefanbenten stefanbenten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally :)

@littleskunk littleskunk merged commit fd72de2 into master Sep 26, 2019
@littleskunk littleskunk deleted the ca/update_version branch September 26, 2019 00:07
@stefanbenten
Copy link
Contributor

@littleskunk You didnt had the label!

@cam-a
Copy link
Contributor Author

cam-a commented Sep 26, 2019

That's okay

littleskunk pushed a commit that referenced this pull request Sep 26, 2019
@cam-a @littleskunk
satellite/satellitedb: update node version columns in UpdateCheckIn (#…
44a7db6 
…3129)

* update node version columns in UpdateCheckIn

* tests and fix sqlite implementation

* check timestamps

* edit timestamp check

(cherry picked from commit fd72de2)
@littleskunk littleskunk added the Reviewer Can Merge If all checks have passed, non-owner can merge PR label Sep 26, 2019
@littleskunk
Copy link
Member

@stefanbenten better now? :D

JessicaGreben
JessicaGreben reviewed Sep 26, 2019
View reviewed changes
Copy link
Contributor

@JessicaGreben JessicaGreben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing @cam-a, this looks great

bryanchriswhite added a commit that referenced this pull request Sep 26, 2019
@bryanchriswhite
Merge remote-tracking branch 'storj/master' into bryan/certificates
448ffbf 
* storj/master:
  web/satellite: vue style guide applying for UI (#3112)
  internal/testplanet: ensure monitor chore is finished before contacting satellite (#3124)
  build: make binaries smaller with -s and -w ldflags (#3125)
  satellite/satellitedb: update node version columns in UpdateCheckIn (#3129)
  all: use pkg/rpc instead of pkg/transport
  internal/version: Change default endpoint to query (#3126)
  satellite/satellitedb: Initial GE Satellite DB Implementation (#3049)
  satellite/accounting/rollup: pause in tests (#3122)
  jenkins: update golangci to v1.19.1 (#3119)
  satellite/accounting/tally: ensure we have a root piece id (#3123)
  internal/testplanet: set intervals to 15s by default (#3103)
  jenkins: disable flaky test-certificates (#3111)
  storagenode: avoid starting command on service stop (#3105)
  storagenode/winsvc: avoid the 15s sleep when stopping the service (#3098)
  fix certificates auth export command (#3110)
  satellite/repair/checker: set erasure share size in tests (#3101)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JessicaGreben JessicaGreben JessicaGreben left review comments

@littleskunk littleskunk littleskunk approved these changes

@stefanbenten stefanbenten stefanbenten approved these changes

@VinozzZ VinozzZ Awaiting requested review from VinozzZ

Assignees
No one assigned
Labels
cla-signed Reviewer Can Merge If all checks have passed, non-owner can merge PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cam-a @stefanbenten @littleskunk @JessicaGreben