Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add mykola siedov to clabot #3293

Merged
merged 1 commit into from
Oct 16, 2019
Merged

add mykola siedov to clabot #3293

merged 1 commit into from
Oct 16, 2019

Conversation

jtolio
Copy link
Member

@jtolio jtolio commented Oct 16, 2019 •
edited by stefanbenten
Loading

Change-Id: I10a498233d181706a8b3149b18c015d20a101b8d

What: Add Mykola Siedov

Why: Employee

Code Review Checklist (to be filled out by reviewer)

  • Does the PR describe what changes are being made?
  • Does the PR describe why the changes are being made?
  • Does the code follow our style guide?
  • Does the code follow our testing guide?
  • Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
  • Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • Does any documentation need updating?
  • Do the database access patterns make sense?

@jtolio
add siedov mykola to clabot
b7a9b00 
Change-Id: I10a498233d181706a8b3149b18c015d20a101b8d
@jtolio jtolio requested a review from a team October 16, 2019 14:10
@cla-bot cla-bot bot added the cla-signed label Oct 16, 2019
@ghost ghost requested review from crawter and VinozzZ and removed request for a team October 16, 2019 14:10
@jtolio jtolio changed the title add siedov mykola to clabot add mykola siedev to clabot Oct 16, 2019
@rikysya rikysya self-requested a review October 16, 2019 14:11
@jtolio jtolio changed the title add mykola siedev to clabot add mykola siedov to clabot Oct 16, 2019
stefanbenten
stefanbenten approved these changes Oct 16, 2019
View reviewed changes
Copy link
Contributor

@stefanbenten stefanbenten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was just about to do that. lol

@jtolio jtolio merged commit bbe89ec into master Oct 16, 2019
@jtolio jtolio deleted the jt/nikolai2 branch October 16, 2019 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rikysya rikysya rikysya approved these changes

@stefanbenten stefanbenten stefanbenten approved these changes

@VinozzZ VinozzZ VinozzZ approved these changes

@crawter crawter Awaiting requested review from crawter

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jtolio @rikysya @stefanbenten @VinozzZ