lib/uplinkc: Add and export restrict_api_key

[TopperDEL]

With this PR the function "restrict_api_key" is made available to uplinkc.

What: Include "restrict_api_key" within uplinkc

Why: uplinkc lacks that feature currently

Please describe the performance impact: none

Code Review Checklist (to be filled out by reviewer)

• Does the PR describe what changes are being made?
• Does the PR describe why the changes are being made?
• Does the code follow our style guide?
• Does the code follow our testing guide?
• Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
• Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
• Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
• Does any documentation need updating?
• Do the database access patterns make sense?

[stefanbenten]

@TopperDEL Is it on purpose to be made against another branch instead of master?

[TopperDEL]

I'm not so used with GitHub - but the base for my PR is the branch of bryan that is not yet merged - so i wanted to merge into his branch...

[egonelbre]

Some of the review comments are more directed towards @bryanchriswhite.

[TopperDEL]

I need some help with in-depth adjustments to the code.

[mniewrzal]

@TopperDEL I will try to help but I'm not sure I will have time today.

[TopperDEL]

Thanks! Does not have to be today.

[TopperDEL]

@mniewrzal Can we schedule a call for Friday at around 9 o'clock (GMT) which should be 8 o'clock (UTC)?

[mniewrzal]

@mniewrzal Can we schedule a call for Friday at around 9 o'clock (GMT) which should be 8 o'clock (UTC)?

yeah, sounds good

[TopperDEL]

@mniewrzal I'm ready. How can we meet up?

[mniewrzal]

@mniewrzal I'm ready. How can we meet up?

hey, lets try this https://meet.google.com/tsh-giaa-kvk?authuser=1

[TopperDEL]

This should be finished now. Can someone else have a look at it?
@mniewrzal @egonelbre @bryanchriswhite

[ifraixedes]

@TopperDEL I wanted to give you a heads up. We have a few people unavailable for several days due to different personal reasons, so we are not forgetting about this but the review will take more time than usual.

Our apologies.

[TopperDEL]

That's ok, Thanks for the heads-up! @ifraixedes

[TopperDEL]

Any news on this one?

[mniewrzal]

Any news on this one?

@TopperDEL I'm super sorry for the delay. W discuss how we should proceed with exposing sharing capabilities with uplinkc and we need to do this around Scope type. I pushed initial PR for that (#3689 ). Next step will be to add something like:

func restrict_scope(scopeHandle C.ScopeRef, caveat C.Caveat, restrictions **C.EncryptionRestriction, cerr **C.char) C.ScopeRef 

similar to your function but needs to cover also caveats.

[TopperDEL]

Thanks @mniewrzal - I'm not sure if I completely get what you mean. I don't know what "scope" is in this case and how it interacts with a "caveat".

Is there something I can do? Will your PR #3689 render my restrict_api_key from this PR obsolete?

[mniewrzal]

Scope is a concept that is not exposed in uplinkc yet. Its keeping together satellite address, api key and encryption access. You can find it if you are using uplink cmd command by executing uplink share.

PR #3689 won't be adding restrict_scope, it should be separate PR. Regarding your help we have two ways: you can try making new version of restrict_scope (with my help) or wait for PR and review/test it on your side. New restrict_scope will be almost copy of your PR but with caveats and we also need unit test to verify it works as expected.

[TopperDEL]

@mniewrzal Thanks for clarification! Would love to help on this one but this would need some further insights from you. Might we schedule a call again for Friday (again around 9 o'clock (GMT) which should be 8 o'clock (UTC))?

[mniewrzal]

@mniewrzal Thanks for clarification! Would love to help on this one but this would need some further insights from you. Might we schedule a call again for Friday (again around 9 o'clock (GMT) which should be 8 o'clock (UTC))?

I'm not sure if I will be available then but ping me 30 min earlier with email and I will confirm.

[TopperDEL]

This PR is not necessary anymore, as PR #3724 introduces the new restrict_scope-function.

Therefore I'm closing this one.