satellite/gracefulexit: Add graceful exit completed/failed receipt verification to satellite CLI #3679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….com/storj/storj into green/graceful-exit-signature-verify
ghost
removed their request for review
ethanadams
added
Request Code Review
VinozzZ
reviewed
Dec 2, 2019
cmd/satellite/gracefulexit.go
Outdated
| @@ -98,3 +104,46 @@ func generateGracefulExitCSV(ctx context.Context, completed bool, start time.Tim | |||
| } | |||
| return err | |||
| } | |||
|
|
|||
| func verifyGracefulExitReceipt(ctx context.Context, identity *identity.FullIdentity, receipt string) error { | |||
There was a problem hiding this comment.
Maybe we should also have an input for the requested storage node id so we can check that the receipt is actually for that storage node?
VinozzZ
reviewed
Dec 3, 2019
VinozzZ
previously approved these changes
Dec 3, 2019
mobyvb
reviewed
Dec 3, 2019
| } | ||
|
|
||
| // Check the receipt is not empty | ||
| nodeID, err := storj.NodeIDFromString(args[0]) |
There was a problem hiding this comment.
if the first arg is nodeID, the usage description and minimum args needs to be updated, right?
VinozzZ
previously approved these changes
Dec 3, 2019
cmd/satellite/main.go
Outdated
| zap.S().Fatal(err) | ||
| } | ||
|
|
||
| // Check the receipt is not empty |
There was a problem hiding this comment.
nit - the comment here is a little misleading?
There was a problem hiding this comment.
fixed. old comment :)
VinozzZ
approved these changes
Dec 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Add graceful exit completed/failed receipt verification to satellite CLI
Why:
We want to be able to verify a completed/failed receipt if a storage node opens a ticket related to payouts for graceful exit.
Please describe the tests:
Please describe the performance impact:
Code Review Checklist (to be filled out by reviewer)