Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

satellite/console: project usage limits api #3702

Merged
merged 4 commits into from
Dec 12, 2019
Merged

satellite/console: project usage limits api #3702

merged 4 commits into from
Dec 12, 2019

Conversation

rikysya
Copy link
Contributor

@rikysya rikysya commented Dec 5, 2019 •
edited

What: add project usage limits api

Why: to show limits and usage on UI

Please describe the tests:

  • Test 1:
  • Test 2:

Please describe the performance impact:

Code Review Checklist (to be filled out by reviewer)

  • NEW: Are there any Satellite database migrations? Are they forwards and backwards compatible?
  • Does the PR describe what changes are being made?
  • Does the PR describe why the changes are being made?
  • Does the code follow our style guide?
  • Does the code follow our testing guide?
  • Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
  • Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • Does any documentation need updating?
  • Do the database access patterns make sense?

@rikysya rikysya added the Request Code Review Code review requested label Dec 5, 2019
@rikysya rikysya requested a review from a team December 5, 2019 20:00
@rikysya rikysya self-assigned this Dec 5, 2019
@cla-bot cla-bot bot added the cla-signed label Dec 5, 2019
@ghost ghost requested review from cam-a and navillasa and removed request for a team December 5, 2019 20:00
@rikysya rikysya merged commit 77839dd into master Dec 12, 2019
@rikysya rikysya deleted the yv/satellite/console_project_limits_api branch December 12, 2019 12:58
bryanchriswhite added a commit that referenced this pull request Dec 12, 2019
@bryanchriswhite
Merge remote-tracking branch 'storj/master' into jt/delete-enc
15c1920 
* storj/master: (436 commits)
  satellite/console: project usage limits api (#3702)
  web/storagenode: charts titles aligned
  cmd/segment-reaper: test processSegment for single project
  web/satellite: add tracking event for segment.io (#3641)
  cmd/storj-sim: make initial provisioning nicer
  adding Igor Gaidaenko our new team member! (#3726)
  segment-reaper: fix for not analyzing last project in detect command
  satellite/metainfo: Return error misusing func
  cmd/storagenode-updater, pkg/process: Fix logging timestamp
  storagenodedb: reenable utccheck in tests
  storagenode/trust: source entry cache
  storagenode/trust: rule and excluders
  projectLimit error message changed (#3718)
  pkg/rpc/rpcpool: add idle expiration to connections
  storage/testsuite: pass ctx in to bulk setup methods
  satellite/metainfo: don't leak error implementation detail (#3722)
  uplink: remove dependency to storage/ (#3720)
  jenkins: run storj-sim integration tests with cockraochdb  (#3723)
  private/dbutil/cockroachutil: keep crdb connstr for tests
  replace planet.Start in tests with planet.Run
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikolaiYurchenko NikolaiYurchenko NikolaiYurchenko approved these changes

@Qweder93 Qweder93 Qweder93 approved these changes

@cam-a cam-a Awaiting requested review from cam-a

@navillasa navillasa Awaiting requested review from navillasa

Assignees

@rikysya rikysya

Labels
cla-signed Request Code Review Code review requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rikysya @NikolaiYurchenko @Qweder93