uplink: remove dependency to storage/ #3720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egonelbre
added
Request Code Review
ghost
requested review from
JessicaGreben and
Qweder93
and removed request for
a team
calebcase
approved these changes
Dec 10, 2019
stefanbenten
approved these changes
Dec 10, 2019
| @@ -49,10 +48,13 @@ func New(project *Project, metainfo *metainfo.Client, streams streams.Store, seg | |||
| } | |||
| } | |||
|
|
|||
| const defaultLookupLimit = 1000 | |||
There was a problem hiding this comment.
Would it make sense to pass this as an config value or pass it through on creation?
There was a problem hiding this comment.
uplink needs to request this from the satellite, because this may vary from satellite-to-satellite.
bryanchriswhite
added a commit
that referenced
this pull request
Dec 12, 2019
* storj/master: (436 commits) satellite/console: project usage limits api (#3702) web/storagenode: charts titles aligned cmd/segment-reaper: test processSegment for single project web/satellite: add tracking event for segment.io (#3641) cmd/storj-sim: make initial provisioning nicer adding Igor Gaidaenko our new team member! (#3726) segment-reaper: fix for not analyzing last project in detect command satellite/metainfo: Return error misusing func cmd/storagenode-updater, pkg/process: Fix logging timestamp storagenodedb: reenable utccheck in tests storagenode/trust: source entry cache storagenode/trust: rule and excluders projectLimit error message changed (#3718) pkg/rpc/rpcpool: add idle expiration to connections storage/testsuite: pass ctx in to bulk setup methods satellite/metainfo: don't leak error implementation detail (#3722) uplink: remove dependency to storage/ (#3720) jenkins: run storj-sim integration tests with cockraochdb (#3723) private/dbutil/cockroachutil: keep crdb connstr for tests replace planet.Start in tests with planet.Run ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove dependency to "storj/storage". This helps to split the repositories.
Please describe the tests:
Please describe the performance impact:
Code Review Checklist (to be filled out by reviewer)