Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

satellite/coinpayments: Reduce update interval to 2 minutes #3897

Merged
merged 5 commits into from
May 29, 2020

Conversation

littleskunk
Copy link
Member

@littleskunk littleskunk commented May 21, 2020

What: Reduce the coinpayment update interval from 30 minutes to 2 minutes.

Why: Customers are creating support tickets because the transaction is confirmed but for 30 minutes we didn't allow them to create a project. We are going to change that with a hotfix. This PR is to make sure we also fix the default value and I want to reference this PR in the hotfix.

Please describe the tests:

  • Test 1:
  • Test 2:

Please describe the performance impact:

Code Review Checklist (to be filled out by reviewer)

  • NEW: Are there any Satellite database migrations? Are they forwards and backwards compatible?
  • Does the PR describe what changes are being made?
  • Does the PR describe why the changes are being made?
  • Does the code follow our style guide?
  • Does the code follow our testing guide?
  • Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
  • Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • Does any documentation need updating?
  • Do the database access patterns make sense?

@littleskunk littleskunk requested a review from a team May 21, 2020 14:14
@cla-bot cla-bot bot added the cla-signed label May 21, 2020
@ghost ghost requested review from jenlij and thepaul and removed request for a team May 21, 2020 14:14
@littleskunk littleskunk added Request Code Review Code review requested Reviewer Can Merge If all checks have passed, non-owner can merge PR labels May 21, 2020
@simongui simongui self-requested a review May 26, 2020 16:19
@littleskunk littleskunk merged commit 801a3ab into master May 29, 2020
@littleskunk littleskunk deleted the jh/storj branch May 29, 2020 20:21
Sembeth added a commit to Sembeth/storj that referenced this pull request May 30, 2020
satellite/coinpayments: Reduce update interval to 2 minutes (storj#3897)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Request Code Review Code review requested Reviewer Can Merge If all checks have passed, non-owner can merge PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants