Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create uplink-cli-ux.md #4023

Closed
wants to merge 2 commits into from
Closed

Create uplink-cli-ux.md #4023

wants to merge 2 commits into from

Conversation

iglesiasbrandon
Copy link
Contributor

@iglesiasbrandon iglesiasbrandon commented Jan 15, 2021

What: a proposal for how the uplink CLU UX should be

Why: we want to get feedback from oour community about this proposal

Please describe the tests:

  • Test 1: N/A
  • Test 2: N/A

Please describe the performance impact:

Code Review Checklist (to be filled out by reviewer)

  • NEW: Are there any Satellite database migrations? Are they forwards and backwards compatible?
  • Does the PR describe what changes are being made?
  • Does the PR describe why the changes are being made?
  • Does the code follow our style guide?
  • Does the code follow our testing guide?
  • Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
  • Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • Does any documentation need updating?
  • Do the database access patterns make sense?

@iglesiasbrandon iglesiasbrandon requested a review from a team January 15, 2021 13:45
@cla-bot cla-bot bot added the cla-signed label Jan 15, 2021
@iglesiasbrandon iglesiasbrandon added the WIP Work In Progress label Jan 17, 2021
Change-Id: I7799288a816705b1407f2bdaa105eabd57495af4
@calebcase calebcase removed their request for review April 9, 2021 18:35
@jtolio
Copy link
Member

jtolio commented Nov 2, 2021

now defined better by the real life uplinkng than this document.

@jtolio jtolio closed this Nov 2, 2021
@egonelbre egonelbre deleted the uplinkcliux branch November 3, 2021 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed WIP Work In Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants