Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Travis with go1.11 and modules #479

Merged
merged 15 commits into from
Oct 16, 2018
Merged

Travis with go1.11 and modules #479

merged 15 commits into from
Oct 16, 2018

Conversation

egonelbre
Copy link
Member

@egonelbre egonelbre commented Oct 16, 2018 •
edited
Loading

This PR sets up:

  1. Travis to use Go 1.11
  2. Use go modules instead of storj-vendor
  3. Automatic caching of downloaded dependencies
  4. Ensures that modules incompatible linters run

@egonelbre egonelbre added the WIP Work In Progress label Oct 16, 2018
@cla-bot cla-bot bot added the cla-signed label Oct 16, 2018
@egonelbre egonelbre changed the title Migrate to go1.11 and modules Travis with go1.11 and modules Oct 16, 2018
@egonelbre egonelbre removed the WIP Work In Progress label Oct 16, 2018
brimstone
brimstone approved these changes Oct 16, 2018
View reviewed changes
Copy link
Contributor

@brimstone brimstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@egonelbre egonelbre merged commit 51ae3d6 into master Oct 16, 2018
@egonelbre egonelbre deleted the ee/gospace branch October 16, 2018 17:02
iglesiasbrandon pushed a commit that referenced this pull request Dec 7, 2018
@egonelbre
Travis with go1.11 and modules (#479)
7abf7fc 
* Travis uses Go 1.11
* Use go modules instead of storj-vendor
* Automatic caching of downloaded dependencies
* Ensures that modules incompatible linters run with modules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brimstone brimstone brimstone approved these changes

@coyle coyle coyle approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@egonelbre @brimstone @coyle