Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MPU: last part gets discarded if it doesn't hold bytes #78

Closed
amwolff opened this issue Feb 1, 2022 · 1 comment
Closed

MPU: last part gets discarded if it doesn't hold bytes #78

amwolff opened this issue Feb 1, 2022 · 1 comment
Assignees
@mniewrzal
Labels
bug Something isn't working question Further information is requested

Comments

@amwolff
Copy link
Member

amwolff commented Feb 1, 2022

If the last part is empty (but it can have ETag), it will get discarded during the ListUploadParts action. Reproduction: https://review.dev.storj.io/c/storj/uplink/+/6775. Is it intended behavior?
@amwolff amwolff added bug Something isn't working question Further information is requested labels Feb 1, 2022
@mniewrzal mniewrzal transferred this issue from storj/team-metainfo Feb 1, 2022
@mniewrzal mniewrzal mentioned this issue Feb 1, 2022
Closed
@mniewrzal mniewrzal self-assigned this Feb 2, 2022
@mniewrzal
Copy link
Contributor

https://review.dev.storj.io/c/storj/uplink/+/6776

storjBuildBot pushed a commit that referenced this issue Feb 2, 2022
@mniewrzal
uplink: allow last part to be empty while mpu
cd9f754 
At some point we avoid creating empty segments at the
end of part. It was optimization to reduce number of
segments in DB. Turns out that we need to allow for
empty part at the end of MPU to be compatible with s3.

https: //github.com//issues/78

Change-Id: I8eb05829dcb11401529c43394e2fc01da1ab34c8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mniewrzal mniewrzal

Labels
bug Something isn't working question Further information is requested
Projects
Metainfo Team
Status: Done/Deployed
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mniewrzal @amwolff