This repository has been archived by the owner on Dec 13, 2018. It is now read-only.
more change-password fixes #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We fixed the invalid token case, but broke the valid token case.
|
I've verified that this behaves as expected for both invalid and valid tokens. And I've tried this on both the Angular and Express project. Tests looks good too, nice work 🍻 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another fix for #385. In #388 we fixed the invalid token case but broke the valid token case in ef8822a.
I've added more tests to ensure that we don't break this API in the future, we also need to look at the email verification API to ensure that it is working correctly for JSON and that it has tests.