This repository has been archived by the owner on Dec 13, 2018. It is now read-only.
Fixing JSON response for verifying password reset tokens #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the failure case, we need to render a JSON error message (not redirect to the login page)
|
This works as advertised! :) Though I cleaned it up a little bit and changed so that the method only accepts GET and POST requests. |
|
Thanks @typerandom ! |
robertjd
added a commit
that referenced
this pull request
Mar 17, 2016
Fixing JSON response for verifying password reset tokens
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the failure case, we need to render a JSON error message (not redirect to the login page). Fixes #385
To verify:
With the fix, you should see the error message: "This password reset link is not valid. You may request another link by clicking here." (Expected behaviour)
Without the fix, you should see the change password (problem behaviour).
I've added a new test for HTML vs JSON on this endpoint, and refeactored this test file to use a single default express application (where possible)..