This repository has been archived by the owner on Dec 12, 2018. It is now read-only.
Coverage jacoco coveralls #496
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dogeared
commented
Feb 28, 2016
dogeared
commented
- Adds Jacoco test configuration for surefire and failsafe plugins
- Adds jacoco-mulit-coverage module for creating local aggregated coverage reports for unit and integration tests. This is necessary as jacoco does not natively support aggregated reports for multi-module maven projects
- Adds coveralls.io build to .travis.yml to report on aggregated code coverage for unit and integration tests.
- Moves docs build to oraclejdk7 from oraclejdk8
- Moves ITs run from jdk6 to jdk8 (reason is that maven coveralls plugin has to be jdk7 or newer AND we want the coveralls report to run after both unit and integration tests are run)
- Adds an initial unit test to oauth package as none existed before. This ensures that the oauth package is included in the stats for coverage
- Adds shell script to run all unit and integration tests and produce local aggregated coverage report
…dded jacoco-multi-coverage to aggregate all coverage data for local runs. refactored root pom.xml to include coverage data for integration tests as well as unit tests.
…ted jacoco coverage report. Switched running of ITs on travis to jdk 1.7 so that coveralls plugin will run as 1.6 is not supported.
…kage to aggregated report.
| @@ -122,6 +122,6 @@ public AccountStore getAccountStore() { | |||
| /* @since 1.0.RC5 */ | |||
| @Override | |||
| public AuthenticationOptions getResponseOptions() { | |||
| throw new UnsupportedOperationException(getClass().getName() + " .getResponseOptions() is not supported."); | |||
| throw new UnsupportedOperationException(getClass().getName() + ".getResponseOptions() is not supported."); | |||
There was a problem hiding this comment.
Writing the test for this exposed the extra space in the message.
|
|
||
| @Test | ||
| public void testGetResponseOptions() { | ||
|
|
There was a problem hiding this comment.
Remove the first blank line in each method please
There was a problem hiding this comment.
in previous reviews, I though you'd said our standard was to have a blank for each method. Or, is that for classes?
|
@dogeared back to you |
| @@ -19,7 +20,8 @@ before_install: | |||
| -Dexpression=project.version|grep -Ev '(^\[|Download\w+:)')" | |||
| - export IS_RELEASE="$([ ${RELEASE_VERSION/SNAPSHOT} == $RELEASE_VERSION ] && [ $TRAVIS_BRANCH | |||
| == 'master' ] && echo 'true')" | |||
| - export BUILD_DOCS="$([ $TRAVIS_JDK_VERSION == 'oraclejdk8' ] && echo 'true')" | |||
| - export BUILD_DOCS="$([ $TRAVIS_JDK_VERSION == 'oraclejdk7' ] && echo 'true')" | |||
There was a problem hiding this comment.
Why did you change this to JDK7?
There was a problem hiding this comment.
I moved the run of the ITs to JDK8. So, I moved the build docs to JDK7 to keep the time for each JDK build as short as possible.
|
Closing (for now) to investigate clover. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.