refactor(str-1689): ♻️ make button a simple button #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…mit when used inside a form
lorenaramonda
force-pushed
the
feature/STR-1689-fix-button
branch
from
50d1a5e
to
0e3a23a
Compare
lisilinhart
approved these changes
Apr 4, 2023
|
🎉 This PR is included in version 3.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:-->
How to test this PR
What is the new behavior?
This PR set the type of the button to "button" so it won't trigger submit when used inside a form
Other information
To see the problem in action without the 'button' type specification you can go here: https://github.com/storyblok/storyfront/pull/3654 and test in the develop env: Space > Settings > Webhook > New webhook.
Write in a field and press enter: it will toggle the accordion because these accordion button act as submit as the slideover is wrapped inside a form element