Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Storybook 8 #228

Merged
merged 8 commits into from
Mar 11, 2024
Merged

Upgrade to Storybook 8 #228

merged 8 commits into from
Mar 11, 2024

Conversation

ShaunEvening
Copy link
Contributor

@ShaunEvening ShaunEvening commented Jan 17, 2024

What changed

  • Update to node 18
  • Update Storybook to v8
  • Update React to v18
  • Add @storybook/addon-webpack5-compiler-swc for compiler
  • Remove mdx-gfm addon
  • Replace use of @storybook/addons with @storybook/manager-api and @storybook/preview-api

Version

Published prerelease version: v8.0.0-next.1

Changelog

⚠️ Pushed to next

Authors: 2

Copy link

socket-security bot commented Jan 17, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@auto-it/released@11.0.4 Transitive: environment, eval, filesystem, network, shell, unsafe +183 90.1 MB alisowski
npm/@babel/core@7.23.9 environment, filesystem, unsafe Transitive: shell +52 10.8 MB nicolo-ribaudo
npm/@babel/preset-env@7.23.9 environment Transitive: filesystem, shell, unsafe +161 14.7 MB nicolo-ribaudo
npm/@babel/preset-react@7.23.3 Transitive: environment, filesystem, shell, unsafe +60 10.9 MB nicolo-ribaudo
npm/@babel/preset-typescript@7.23.3 Transitive: environment, filesystem, shell, unsafe +64 11.4 MB nicolo-ribaudo
npm/@figspec/components@1.0.3 Transitive: environment +6 3.1 MB pockawoooh
npm/@storybook/addon-actions@8.0.0-beta.3 Transitive: environment +9 3.85 MB hypnosphi, igor-dv, jreinhold, ...5 more
npm/@storybook/addon-docs@7.6.17 Transitive: environment, eval, filesystem, network, shell, unsafe +359 266 MB shilman
npm/@storybook/addon-docs@8.0.0-beta.3 Transitive: environment, eval, filesystem, network, shell, unsafe +329 261 MB hypnosphi, igor-dv, jreinhold, ...5 more
npm/@storybook/addon-links@8.0.0-beta.3 Transitive: environment +7 1.09 MB hypnosphi, igor-dv, jreinhold, ...5 more
npm/@storybook/addon-storysource@8.0.0-beta.3 Transitive: environment, eval, filesystem +48 10.1 MB shilman
npm/@storybook/blocks@7.6.17 eval Transitive: environment, filesystem, network, shell, unsafe +234 248 MB shilman
npm/@storybook/components@7.6.17 environment, eval Transitive: filesystem +115 25.1 MB shilman
npm/@storybook/components@8.0.0-beta.3 Transitive: environment, eval, filesystem +62 18.6 MB hypnosphi, igor-dv, jreinhold, ...5 more
npm/@storybook/core-events@8.0.0-beta.3 None +1 111 kB hypnosphi, igor-dv, jreinhold, ...5 more
npm/@storybook/manager-api@8.0.0-beta.3 Transitive: environment, eval, filesystem +56 14.3 MB alexandrebodin, amalik2, dandean, ...23 more
npm/@storybook/preview-api@8.0.0-beta.3 Transitive: environment, eval, filesystem +48 8.51 MB alexandrebodin, amalik2, dandean, ...23 more
npm/@storybook/react-webpack5@8.0.0-beta.3 Transitive: environment, eval, filesystem, network, shell, unsafe +516 338 MB alexandrebodin, amalik2, dandean, ...23 more
npm/@storybook/react@8.0.0-beta.3 Transitive: environment, eval, filesystem, network, shell, unsafe +275 310 MB hypnosphi, igor-dv, jreinhold, ...5 more
npm/@storybook/theming@7.6.17 environment +10 5.76 MB shilman
npm/@storybook/theming@8.0.0-beta.3 Transitive: environment +10 5.76 MB hypnosphi, igor-dv, jreinhold, ...5 more
npm/@types/react-dom@18.2.19 None +4 1.71 MB types
npm/@types/react@18.2.57 None +3 1.68 MB types
npm/@types/webpack-env@1.18.4 None 0 16.7 kB types
npm/auto@11.0.4 Transitive: environment, eval, filesystem, network, shell, unsafe +225 91 MB alisowski
npm/examples@0.1.0 None 0 19.8 kB jonschlinkert
npm/react-dom@18.2.0 environment +4 4.93 MB gnoff
npm/react@18.2.0 environment +2 337 kB gnoff
npm/storybook@8.0.0-beta.3 Transitive: environment, eval, filesystem, network, shell, unsafe +622 284 MB ndelangen, shilman, usulpro

🚮 Removed packages: npm/@auto-it/released@11.0.1, npm/@babel/core@7.22.5, npm/@babel/preset-env@7.22.5, npm/@babel/preset-react@7.22.5, npm/@babel/preset-typescript@7.22.5, npm/@figspec/components@1.0.1, npm/@storybook/addon-actions@7.0.24, npm/@storybook/addon-docs@7.0.24, npm/@storybook/addon-links@7.0.24, npm/@storybook/addon-mdx-gfm@7.0.26, npm/@storybook/addon-storysource@7.0.24, npm/@storybook/addons@7.0.24, npm/@storybook/blocks@7.0.24, npm/@storybook/components@7.0.24, npm/@storybook/core-events@7.0.24, npm/@storybook/manager-api@7.0.24, npm/@storybook/mdx1-csf@1.0.0, npm/@storybook/preview-api@7.0.24, npm/@storybook/react-webpack5@7.0.24, npm/@storybook/react@7.0.24, npm/@storybook/theming@7.0.24, npm/@types/react-dom@17.0.20, npm/@types/react@17.0.62, npm/@types/webpack-env@1.18.1, npm/auto@11.0.1, npm/react-dom@17.0.2, npm/react@17.0.2, npm/storybook@7.0.24

View full report↗︎

Copy link

socket-security bot commented Jan 17, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/assert@2.1.0, npm/foreground-child@3.1.1, npm/get-stream@8.0.1, npm/handlebars@4.7.8, npm/react-dom@18.2.0, npm/react@18.2.0, npm/scheduler@0.23.0

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@ndelangen
Copy link
Member

@SocketSecurity ignore @sinclair/typebox@0.27.8
@SocketSecurity ignore @storybook/addon-actions@8.0.0-alpha.10
@SocketSecurity ignore @storybook/addon-links@8.0.0-alpha.10
@SocketSecurity ignore @storybook/manager@8.0.0-alpha.10
@SocketSecurity ignore @storybook/preview@8.0.0-alpha.10
@SocketSecurity ignore assert@2.1.0
@SocketSecurity ignore react@18.2.0
@SocketSecurity ignore react-dom@18.2.0
@SocketSecurity ignore scheduler@0.23.0
@SocketSecurity ignore hasown@2.0.0
@SocketSecurity ignore handlebars@4.7.8
@SocketSecurity ignore get-stream@8.0.1
@SocketSecurity ignore foreground-child@3.1.1

@ndelangen
Copy link
Member

@SocketSecurity ignore npm/react@18.2.0
@SocketSecurity ignore npm/react-dom@18.2.0
@SocketSecurity ignore npm/scheduler@0.23.0
@SocketSecurity ignore npm/foreground-child@3.1.1
@SocketSecurity ignore npm/handlebars@4.7.8
@SocketSecurity ignore npm/assert@2.1.0
@SocketSecurity ignore npm/get-stream@8.0.1

@ndelangen
Copy link
Member

@yannbf I think these version ranges should make it future compatible.. WDYT?

@yannbf
Copy link
Member

yannbf commented Mar 4, 2024

@ndelangen maybe the range is good, but I think we should test a canary just to be sure

Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder NOT to merge this PR until Storybook 8 reaches stable. In the time being, as we push to this branch, a new next version will be generated.

@JReinhold JReinhold merged commit 18bba6b into master Mar 11, 2024
4 checks passed
@JReinhold JReinhold deleted the next branch March 11, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants