Require Svelte v4, vite-plugin-svelte v2, Vite v4 #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JReinhold
added
major
benmccann
approved these changes
Aug 24, 2023
JReinhold
changed the title
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works on #121 (comment)
cc @RSWilli
This PR upgrades the required peer dependencies:
@sveltejs/vite-plugin-svelte:^2.0.0svelte:^4.0.0vite:^4.0.0And recreates the typing changes introduced in #112 to support Svelte v4.
Telescopes on top of #127 to release a new major version. Don't merge until that has been merged and released.
@benmccann I figured I'd use this breaking opportunity to upgrade Vite and the Vite plugin, do you see any issue in that? Are the older versions still used a lot for some reason?
I've tested that this still works with types by installing this canary in a Svelte v3 project and see that it fails, and then upgrading to Svelte v4 and see that it works.
📦 Published PR as canary version:
4.0.0--canary.128.b77ea51.0✨ Test out this PR locally via:
npm install @storybook/addon-svelte-csf@4.0.0--canary.128.b77ea51.0 # or yarn add @storybook/addon-svelte-csf@4.0.0--canary.128.b77ea51.0