Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Storybook 8 #165

Merged
merged 8 commits into from
Feb 9, 2024
Merged

Support Storybook 8 #165

merged 8 commits into from
Feb 9, 2024

Conversation

JReinhold
Copy link
Collaborator

@JReinhold JReinhold commented Jan 23, 2024

Fixes #172

📦 Published PR as canary version: 4.1.2--canary.165.7a12aa9.0

✨ Test out this PR locally via:

npm install @storybook/addon-svelte-csf@4.1.2--canary.165.7a12aa9.0
# or 
yarn add @storybook/addon-svelte-csf@4.1.2--canary.165.7a12aa9.0

Version

Published prerelease version: v4.1.2-next.0

Changelog

🐛 Bug Fix

Authors: 1

@JReinhold JReinhold self-assigned this Jan 23, 2024
@JReinhold JReinhold added patch Increment the patch version when merged dependencies Update one or more dependencies version labels Jan 23, 2024
Copy link

socket-security bot commented Jan 23, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@storybook/addon-actions@8.0.0-beta.1 Transitive: environment +9 3.89 MB hypnosphi, igor-dv, jreinhold, ...5 more
npm/@storybook/addon-essentials@8.0.0-beta.1 Transitive: environment, eval, filesystem, network, shell, unsafe +331 64.4 MB hypnosphi, igor-dv, jreinhold, ...5 more
npm/@storybook/addon-interactions@8.0.0-beta.1 Transitive: environment, eval, filesystem +47 13.8 MB alexandrebodin, amalik2, dandean, ...23 more
npm/@storybook/blocks@8.0.0-beta.1 Transitive: environment, eval, filesystem, network, shell, unsafe +268 51.4 MB alexandrebodin, amalik2, dandean, ...26 more
npm/@storybook/client-logger@8.0.0-beta.1 None +1 11.6 kB hypnosphi, igor-dv, jreinhold, ...5 more
npm/@storybook/components@8.0.0-beta.1 Transitive: environment, eval, filesystem +56 18.1 MB hypnosphi, igor-dv, jreinhold, ...5 more
npm/@storybook/node-logger@8.0.0-beta.1 None 0 168 kB hypnosphi, igor-dv, jreinhold, ...5 more
npm/@storybook/preview-api@8.0.0-beta.1 Transitive: environment, eval, filesystem +41 6.72 MB alexandrebodin, amalik2, dandean, ...23 more
npm/@storybook/svelte-vite@8.0.0-beta.1 Transitive: environment, eval, filesystem, network, shell, unsafe +419 104 MB alexandrebodin, amalik2, dandean, ...23 more
npm/@storybook/svelte@8.0.0-beta.1 Transitive: environment, eval, filesystem, network, shell, unsafe +323 49.1 MB hypnosphi, igor-dv, jreinhold, ...5 more
npm/@storybook/test@8.0.0-beta.1 Transitive: environment, eval, filesystem, network, shell, unsafe +454 54.5 MB hypnosphi, igor-dv, jreinhold, ...5 more
npm/@storybook/theming@8.0.0-beta.1 Transitive: environment +10 5.76 MB hypnosphi, igor-dv, jreinhold, ...5 more
npm/@storybook/types@8.0.0-beta.1 Transitive: environment, eval, filesystem +36 6.14 MB alexandrebodin, amalik2, dandean, ...23 more
npm/storybook@8.0.0-beta.1 Transitive: environment, eval, filesystem, network, shell, unsafe +598 87.1 MB ndelangen, shilman, usulpro

🚮 Removed packages: npm/@storybook/addon-actions@7.5.2, npm/@storybook/addon-essentials@7.5.2, npm/@storybook/addon-interactions@7.5.2, npm/@storybook/client-api@7.5.2, npm/@storybook/client-logger@7.5.2, npm/@storybook/core-client@7.5.2, npm/@storybook/core-server@7.5.2, npm/@storybook/jest@0.1.0, npm/@storybook/manager-api@7.5.2, npm/@storybook/node-logger@7.5.2, npm/@storybook/svelte-vite@7.5.2, npm/@storybook/svelte@7.5.2, npm/@storybook/test-runner@0.11.0, npm/@storybook/testing-library@0.2.0, npm/@storybook/theming@7.0.0, npm/@storybook/types@7.5.2, npm/storybook@7.5.2

View full report↗︎

@JReinhold
Copy link
Collaborator Author

JReinhold commented Jan 29, 2024

More work is needed here, it seems that the play function is failing.. https://6042cb92fd1bb200234586ee-mgzfdeozwn.chromatic.com/?path=/story/demo-interactions--play

This was fixed when upgrading to SB8, potentially because of the move to @storybook/test

@JReinhold JReinhold changed the title Use @storybook/preview-api Support Storybook 8 Feb 8, 2024
@JReinhold JReinhold changed the base branch from main to next February 8, 2024 12:09
@JReinhold JReinhold marked this pull request as draft February 8, 2024 12:12
Copy link

socket-security bot commented Feb 8, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
New author npm/check-error@1.0.3
New author npm/assert@2.1.0
New author npm/loupe@2.3.7

View full report↗︎

Next steps

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/check-error@1.0.3
  • @SocketSecurity ignore npm/assert@2.1.0
  • @SocketSecurity ignore npm/loupe@2.3.7

@JReinhold JReinhold added minor Increment the minor version when merged patch Increment the patch version when merged and removed patch Increment the patch version when merged minor Increment the minor version when merged labels Feb 8, 2024
@JReinhold JReinhold marked this pull request as ready for review February 9, 2024 08:05
@JReinhold JReinhold merged commit 65626fb into next Feb 9, 2024
6 of 7 checks passed
@shilman shilman added the prerelease This change is available in a prerelease. label Feb 9, 2024
@shilman
Copy link
Member

shilman commented Mar 6, 2024

🚀 PR was released in v4.1.2 🚀

@shilman shilman added released This issue/pull request has been released. and removed prerelease This change is available in a prerelease. labels Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Update one or more dependencies version patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants