Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #173

Merged
merged 2 commits into from
Mar 3, 2024
Merged

Update README.md #173

merged 2 commits into from
Mar 3, 2024

Conversation

LuisEGR
Copy link
Contributor

@LuisEGR LuisEGR commented Feb 20, 2024

Updated the Getting Started instruction number 3, this was quite confusing, initially says add "*.stories.svelte" which if taked literary, one can think of adding this string as a new element to the array, but after closing inspection (because it is not working), one can realize in the example the correct configuration, all this can be avoided if the instructions are clearer.

Updated the Getting Started instruction number 3, this was quite confusing, initially says add "*.stories.svelte" which if taked literary, one can think of adding this string as a new element to the array, but after closing inspection (because it is not working), one can realize in the example the correct configuration, all this can be avoided if the instructions are clearer.
@JReinhold
Copy link
Collaborator

I see what you mean, but I think this proposal could be equally confusing. What about something like

  1. In .storybook/main.js, include .stories.svelte files in your stories patterns, eg. by changing the patterns to '../src/**/*.stories.@(js|jsx|ts|tsx|svelte)'

Updated point 3 of the getting started to avoid confusion.
@LuisEGR
Copy link
Contributor Author

LuisEGR commented Feb 20, 2024

I agree with you, I've just pushed another commit with that change.

@JReinhold JReinhold added documentation Changes only affect the documentation skip-release Preserve the current version when merged labels Mar 3, 2024
@JReinhold JReinhold merged commit cf08bea into storybookjs:main Mar 3, 2024
2 checks passed
@shilman
Copy link
Member

shilman commented Mar 6, 2024

🚀 PR was released in v4.1.2 🚀

@shilman shilman added the released This issue/pull request has been released. label Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Changes only affect the documentation released This issue/pull request has been released. skip-release Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants