Fix dependency on @storybook/node-logger
and @storybook/client-logger
#182
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes:
The core consolidation project will cause unresolved packages to start failing storybook.
This package has such unresolved dependencies.
Mind you this would have already broken
pnp
mode and possible other strict dependency managers.So it's a thing we want to fix, even if the core package consolidation project is delayed or cancelled.
1 solution would be to move these to regular dependencies, instead of devDependencies.
But with the core package consolidation project in mind, removing/reducing the dependency on those packages is a good move.
What I did:
@storybook/node-logger
, I deemed it not important enough to keep.@storybook/client-logger
in the piece of code that's shared between server & browser.The dependency on
@storybook/node-logger
was missing completely!@storybook/client-logger
was being referenced in a piece of code used by both node & browser.This is fine for browser, because of prebundling (globalized in both preview & manager), but this is really bad for node, because:
QA:
I've manually tested this by:
📦 Published PR as canary version:
4.1.3--canary.182.cb1f688.0
✨ Test out this PR locally via:
npm install @storybook/addon-svelte-csf@4.1.3--canary.182.cb1f688.0 # or yarn add @storybook/addon-svelte-csf@4.1.3--canary.182.cb1f688.0