Skip to content
This repository has been archived by the owner on Jun 22, 2023. It is now read-only.

upgrades and add a handling for storybook7 which has no main.js for the manager #12

Merged
merged 17 commits into from
Nov 9, 2022

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Jun 28, 2022

  • upgrades
  • add a failback if main.js is missing (which it is in SB7)
  • switch to playright from puppeteer
📦 Published PR as canary version: 1.0.0--canary.12.7cccdee.0

✨ Test out this PR locally via:

npm install @storybook/bench@1.0.0--canary.12.7cccdee.0
# or 
yarn add @storybook/bench@1.0.0--canary.12.7cccdee.0

Version

Published prerelease version: v1.0.0-next.0

Changelog

💥 Breaking Change

Authors: 2

@ndelangen ndelangen self-assigned this Jun 28, 2022
@socket-security
Copy link

socket-security bot commented Jun 28, 2022

Socket Security Report

Dependency issues detected. If you merge this pull request, you will not be alerted to the instances of these issues again.

📜 New install scripts detected

A dependency change in this PR is introducing new install scripts to your install step.

Package Script field Location
playwright@1.25.1 (added) install package.json
Socket.dev scan summary
Issue Status
Did you mean? ✅ no new possible package typos
Install scripts ⚠️ 1 new install script detected
Telemetry ✅ no new telemetry
Troll package ✅ no new troll packages
Malware ✅ no new malware
Native code ✅ no new native modules

Powered by socket.dev

@ndelangen ndelangen added the major Increment the major version when merged label Jun 28, 2022
@ndelangen ndelangen requested a review from shilman June 28, 2022 15:40
@ndelangen
Copy link
Member Author

@shilman would be great to get #11 merged in here and do a 1.0.0 release? WDYT?

@shilman shilman changed the base branch from main to next November 9, 2022 17:14
@shilman shilman merged commit 081501e into next Nov 9, 2022
@shilman shilman deleted the tech/upgrades-and-prep-for-sb7 branch November 9, 2022 17:15
@shilman
Copy link
Member

shilman commented Nov 9, 2022

🚀 PR was released in v1.0.0-next.0 🚀

@shilman shilman added the prerelease This change is available in a prerelease. label Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
major Increment the major version when merged prerelease This change is available in a prerelease.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants