Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Storybook to 6.5.0 in examples #386

Merged
merged 1 commit into from
May 20, 2022
Merged

Update Storybook to 6.5.0 in examples #386

merged 1 commit into from
May 20, 2022

Conversation

joshwooding
Copy link
Collaborator

No description provided.

@@ -73,7 +73,7 @@ import StackAlt from './assets/stackalt.svg';
display: block;
margin-bottom: 2px;
}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, was not expecting this change but I think it makes sense?

@joshwooding joshwooding requested a review from IanVS May 19, 2022 00:13
@joshwooding
Copy link
Collaborator Author

01:14:53 [vite] ✨ new dependencies optimized: @storybook/react/dist/esm/client/docs/config, @storybook/react/dist/esm/client/preview/config, @storybook/addon-a11y/preview.js, @story
book/addon-links/preview.js, @storybook/addon-docs/preview.js, ...and 4 more
01:14:53 [vite] ✨ optimized dependencies changed. reloading

Investigating 🤔

@IanVS
Copy link
Member

IanVS commented May 19, 2022

I think that's normal, it happens now that we correctly import the config array of addons and whatnot.

@joshwooding
Copy link
Collaborator Author

I think that's normal, it happens now that we correctly import the config array of addons and whatnot.

Ah cool. It only appears when there's no cache so it's not a big deal.

@joshwooding
Copy link
Collaborator Author

Blocked by storybookjs/test-runner#107

@yannbf
Copy link
Member

yannbf commented May 19, 2022

Hey @joshwooding that's been merged and released in 0.1.0!

@joshwooding
Copy link
Collaborator Author

Hey @joshwooding that's been merged and released in 0.1.0!

Nice! Thanks for the update @yannbf :)

languageName: node
linkType: hard

"@storybook/csf-tools@npm:^6.4.3":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for others. We needed to yarn up @storybook/csf-tools here, in order to get an updated version in the lockfile. It's possible this might bite others as well who are upgrading from a previous installation of storybook 6.4 and vite builder. It's something we should probably keep an ear out for, at least. Relying on these kinds of sub-dependencies of storybook packages is a bit fraught. In this case, we'd be better off not having an explicit dependencies list in our package.json, probably. But, once we update the way we handle mdx, this might all be a moot point anyway.

Copy link
Member

@IanVS IanVS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is 🟢 , let's goooo.

@IanVS IanVS merged commit 21f3c20 into main May 20, 2022
@IanVS IanVS deleted the update-storybook-deps branch May 20, 2022 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants