Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Support Storybook 6.5 #107

Merged
merged 5 commits into from
May 19, 2022
Merged

fix: Support Storybook 6.5 #107

merged 5 commits into from
May 19, 2022

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented May 18, 2022

[BREAKING CHANGES]: Drop Storybook 6.4 support

fixes #106

📦 Published PR as canary version: 0.0.9--canary.107.1f96eca.0

✨ Test out this PR locally via:

npm install @storybook/test-runner@0.0.9--canary.107.1f96eca.0
# or 
yarn add @storybook/test-runner@0.0.9--canary.107.1f96eca.0

Release notes

Breaking change 💥

This version adds support to Storybook 6.5 and drops support for Storybook 6.4. Unfortunately there was a breaking change in an internal API from @storybook/store which is used by the test runner, which only affects users that use the auto title feature.

Changes included from this pull request (#107)

Version

Published prerelease version: v0.1.0-next.0

Changelog

Release Notes

fix: Support Storybook 6.5 (#107)

Breaking change 💥

This version adds support to Storybook 6.5 and drops support for Storybook 6.4. Unfortunately there was a breaking change in an internal API from @storybook/store which is used by the test runner, which only affects users that use the auto title feature.

Changes included from this pull request (#107)


🚀 Enhancement

Authors: 3

@valentinpalkovic valentinpalkovic added the feature request New feature or request label May 18, 2022
[BREAKING CHANGES]: Drop Storybook 6.4 support

fixes #106
@valentinpalkovic valentinpalkovic added bug Something isn't working and removed feature request New feature or request labels May 18, 2022
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bunch of stuff, but the makeTitle stuff is super urgent. Thanks so much for catching this @valentinpalkovic and for the quick PR

src/playwright/transformPlaywrightJson.ts Outdated Show resolved Hide resolved
src/playwright/transformPlaywrightJson.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@valentinpalkovic valentinpalkovic changed the title feat: Support Storybook 6.5 fix: Support Storybook 6.5 May 19, 2022
@yannbf yannbf added the minor Increment the minor version when merged label May 19, 2022
@yannbf yannbf merged commit 47385f4 into next May 19, 2022
@yannbf yannbf mentioned this pull request May 19, 2022
@yannbf yannbf deleted the feat-support-storybook-6.5 branch November 18, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working minor Increment the minor version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Error "TypeError: (0 , _store.autoTitle) is not a function" when running test-storybook command
3 participants