Lazily require ember-cli-addon-docs-yuidoc when needed #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 23, 2022
|
The issue has been fixed in npm v8.13.2 Still people are going to hit this if they are using npm < v8.13.2 |
|
It doesn't seem we are going to have an update of npm version soon. Can we have this merge into master until we can have npm v8.13.2 in CI actions? |
dbendaou
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
In an attempt to workaround issue #124, we excluded
yuifrom our dependencies.However, it turns out that
ember-cli-storybookalways requiresember-cli-addon-docs-yuidoc(which requiresyuidocjs, which requiresyui☠️).So, this PR aims at allowing not to have
yuiin our dependencies if it is not used, by lazily requiringember-cli-addon-docs-yuidocwhen it is necessary.Hope this helps.