[TECH] Eviter le no-audit en demandant la version minimum de npm 8.13.2
#282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannbertrand
added
👀 Func Review Needed
👀 Tech Review Needed
cross-team
|
I'm deploying this PR to:
Please check it out! |
|
Doublon de #274 |
octo-topi
approved these changes
Dec 8, 2022
|
#274 est mergée, donc le problème ne se produit plus |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎄 Problème
Avec les versions < 8.13.2 de npm nous avons besoin de lancer le
npm ciavec le param--no-audit.Voir storybookjs/ember-cli-storybook#125.
🎁 Solution
Monter la version minimum de npm à la 8.13.2 pour éviter ce soucis.
🌟 Remarques
On ne fixe plus de version haute pour ne pas limiter les montées de version de npm. En espérant que les nouvelles versions de npm restent compatibles.
🎅 Pour tester
npm install --global npm@latestpour mettre à jour sa version denpm.npm cien local sans--no-audit.