make appetize base url configurable for use with subdomains #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amalik2
requested changes
Nov 30, 2021
amalik2
approved these changes
Dec 1, 2021
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an
appetizeBaseUrlparameter to the renderers that passes through to set the base url for the appetize embed URLFor use cases where there is a custom subdomain for appetize, rather than the public URL
📦 Published PR as canary version:
2.2.1-canary.67.725.0✨ Test out this PR locally via:
npm install @storybook/native-android-material-deep-link-example@2.2.1-canary.67.725.0 npm install @storybook/native-controls-example@2.2.1-canary.67.725.0 npm install @storybook/native-cross-platform-example@2.2.1-canary.67.725.0 npm install @storybook/native-flutter-example@2.2.1-canary.67.725.0 npm install @storybook/native-ios-example-deep-link@2.2.1-canary.67.725.0 npm install @storybook/native-addon@2.2.1-canary.67.725.0 npm install @storybook/native-controllers@2.2.1-canary.67.725.0 npm install @storybook/deep-link-logger@2.2.1-canary.67.725.0 npm install @storybook/native-dev-middleware@2.2.1-canary.67.725.0 npm install @storybook/native-devices@2.2.1-canary.67.725.0 npm install @storybook/native-components@2.2.1-canary.67.725.0 npm install @storybook/native@2.2.1-canary.67.725.0 npm install @storybook/native-types@2.2.1-canary.67.725.0 # or yarn add @storybook/native-android-material-deep-link-example@2.2.1-canary.67.725.0 yarn add @storybook/native-controls-example@2.2.1-canary.67.725.0 yarn add @storybook/native-cross-platform-example@2.2.1-canary.67.725.0 yarn add @storybook/native-flutter-example@2.2.1-canary.67.725.0 yarn add @storybook/native-ios-example-deep-link@2.2.1-canary.67.725.0 yarn add @storybook/native-addon@2.2.1-canary.67.725.0 yarn add @storybook/native-controllers@2.2.1-canary.67.725.0 yarn add @storybook/deep-link-logger@2.2.1-canary.67.725.0 yarn add @storybook/native-dev-middleware@2.2.1-canary.67.725.0 yarn add @storybook/native-devices@2.2.1-canary.67.725.0 yarn add @storybook/native-components@2.2.1-canary.67.725.0 yarn add @storybook/native@2.2.1-canary.67.725.0 yarn add @storybook/native-types@2.2.1-canary.67.725.0